diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-01-10 03:57:25 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-12-20 07:45:10 -0800 |
| commit | 6b047827d4cdd57ac7c4f9da2d779d811649566f (patch) | |
| tree | 9038d794c4561fbf2bf0c578d7432bb4aa93daf2 | |
| parent | 89e6d5d2c91925b16e6eaf2e867325ec3c47d513 (diff) | |
| download | linux-3.10-6b047827d4cdd57ac7c4f9da2d779d811649566f.tar.gz linux-3.10-6b047827d4cdd57ac7c4f9da2d779d811649566f.tar.bz2 linux-3.10-6b047827d4cdd57ac7c4f9da2d779d811649566f.zip | |
Btrfs: fix access_ok() check in btrfs_ioctl_send()
commit 700ff4f095d78af0998953e922e041d75254518b upstream.
The closing parenthesis is in the wrong place. We want to check
"sizeof(*arg->clone_sources) * arg->clone_sources_count" instead of
"sizeof(*arg->clone_sources * arg->clone_sources_count)".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Signed-off-by: Chris Mason <clm@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/btrfs/send.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index 09ea0bdde65..256a9a46d54 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/send.c @@ -4623,8 +4623,8 @@ long btrfs_ioctl_send(struct file *mnt_file, void __user *arg_) } if (!access_ok(VERIFY_READ, arg->clone_sources, - sizeof(*arg->clone_sources * - arg->clone_sources_count))) { + sizeof(*arg->clone_sources) * + arg->clone_sources_count)) { ret = -EFAULT; goto out; } |