summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff Layton <jlayton@redhat.com>2010-08-23 11:38:04 -0400
committerSteve French <sfrench@us.ibm.com>2010-08-23 17:38:31 +0000
commit24e6cf92fde1f140d8eb0bf7cd24c2c78149b6b2 (patch)
tree62ead9abea45977c5c9086284611bcb74f844aa2
parent3ec6bbcdb4e85403f2c5958876ca9492afdf4031 (diff)
downloadlinux-3.10-24e6cf92fde1f140d8eb0bf7cd24c2c78149b6b2.tar.gz
linux-3.10-24e6cf92fde1f140d8eb0bf7cd24c2c78149b6b2.tar.bz2
linux-3.10-24e6cf92fde1f140d8eb0bf7cd24c2c78149b6b2.zip
cifs: check for NULL session password
It's possible for a cifsSesInfo struct to have a NULL password, so we need to check for that prior to running strncmp on it. Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <sfrench@us.ibm.com>
-rw-r--r--fs/cifs/connect.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 18af707f00f..ec0ea4a43bd 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1673,6 +1673,7 @@ cifs_find_smb_ses(struct TCP_Server_Info *server, struct smb_vol *vol)
MAX_USERNAME_SIZE))
continue;
if (strlen(vol->username) != 0 &&
+ ses->password != NULL &&
strncmp(ses->password,
vol->password ? vol->password : "",
MAX_PASSWORD_SIZE))