summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJosef Bacik <jbacik@fusionio.com>2012-08-24 14:48:11 -0400
committerChris Mason <chris.mason@fusionio.com>2012-10-01 15:19:03 -0400
commit0fa83cdb1d72a94ea84ab6380747de6ac7cc8753 (patch)
tree96ca85c63b0d4698555e0a8029ce2bf0c46b0c93
parent5dc562c541e1026df9d43913c2f6b91156e22d32 (diff)
downloadlinux-3.10-0fa83cdb1d72a94ea84ab6380747de6ac7cc8753.tar.gz
linux-3.10-0fa83cdb1d72a94ea84ab6380747de6ac7cc8753.tar.bz2
linux-3.10-0fa83cdb1d72a94ea84ab6380747de6ac7cc8753.zip
Btrfs: only warn if we hit an error when doing the tree logging
I hit this a couple times while working on my fsync patch (all my bugs, not normal operation), but with my new stuff we could have new errors from cases I have not encountered, so instead of BUG()'ing we should be WARN()'ing so that we are notified there is a problem but the user doesn't lose their data. We can easily commit the transaction in the case that the tree logging fails and still be fine, so let's try and be as nice to the user as possible. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com>
-rw-r--r--fs/btrfs/tree-log.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index f2ff02c5513..94db438494d 100644
--- a/fs/btrfs/tree-log.c
+++ b/fs/btrfs/tree-log.c
@@ -3346,7 +3346,7 @@ int btrfs_log_inode_parent(struct btrfs_trans_handle *trans,
end_trans:
dput(old_parent);
if (ret < 0) {
- BUG_ON(ret != -ENOSPC);
+ WARN_ON(ret != -ENOSPC);
root->fs_info->last_trans_log_full_commit = trans->transid;
ret = 1;
}