summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Cox <alan@linux.intel.com>2012-07-12 03:39:11 +0000
committerDavid S. Miller <davem@davemloft.net>2012-07-12 08:33:18 -0700
commit7ac2908e4b2edaec60e9090ddb4d9ceb76c05e7d (patch)
treed57fc177fb246e54995a59444daf517047be5f3b
parentc1f5163de417dab01fa9daaf09a74bbb19303f3c (diff)
downloadlinux-3.10-7ac2908e4b2edaec60e9090ddb4d9ceb76c05e7d.tar.gz
linux-3.10-7ac2908e4b2edaec60e9090ddb4d9ceb76c05e7d.tar.bz2
linux-3.10-7ac2908e4b2edaec60e9090ddb4d9ceb76c05e7d.zip
sch_sfb: Fix missing NULL check
Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=44461 Signed-off-by: Alan Cox <alan@linux.intel.com> Acked-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/sched/sch_sfb.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/sched/sch_sfb.c b/net/sched/sch_sfb.c
index 74305c883bd..30ea4674cab 100644
--- a/net/sched/sch_sfb.c
+++ b/net/sched/sch_sfb.c
@@ -570,6 +570,8 @@ static int sfb_dump(struct Qdisc *sch, struct sk_buff *skb)
sch->qstats.backlog = q->qdisc->qstats.backlog;
opts = nla_nest_start(skb, TCA_OPTIONS);
+ if (opts == NULL)
+ goto nla_put_failure;
if (nla_put(skb, TCA_SFB_PARMS, sizeof(opt), &opt))
goto nla_put_failure;
return nla_nest_end(skb, opts);