diff options
| author | Seung-Woo Kim <sw0312.kim@samsung.com> | 2022-09-23 11:09:52 +0900 |
|---|---|---|
| committer | Seung-Woo Kim <sw0312.kim@samsung.com> | 2022-09-23 13:47:48 +0900 |
| commit | 3332766d0c347e5e1a56f0370a87a378f8216d1d (patch) | |
| tree | 4569fc377e4b6b0e7ebebcd966d78a1f89856fac | |
| parent | 5350352762061a6cf1210bfef5e129e097249405 (diff) | |
| download | pass-3332766d0c347e5e1a56f0370a87a378f8216d1d.tar.gz pass-3332766d0c347e5e1a56f0370a87a378f8216d1d.tar.bz2 pass-3332766d0c347e5e1a56f0370a87a378f8216d1d.zip | |
pass: thermal: Fix to return proper value for dbus signal handlertizen_7.0_m2_releaseaccepted/tizen/unified/20220927.132311accepted/tizen/7.0/unified/hotfix/20221116.105751accepted/tizen/7.0/unified/20221110.063429tizen_7.0_hotfixaccepted/tizen_7.0_unified_hotfix
From the dbus-stub generated code, signal handler should return
TRUE if it handles invocation. Even ret value is error, fix to
return TRUE after handling invocation.
Below is dbus-stub comment about signal handler:
If a signal handler returns %TRUE, it means the signal handler
will handle the invocation and no other signal handlers will
run. If no signal handler handles the invocation, the
%G_DBUS_ERROR_UNKNOWN_METHOD error is returned.
Returns: %G_DBUS_METHOD_INVOCATION_HANDLED or %TRUE if the
invocation was handled,
%G_DBUS_METHOD_INVOCATION_UNHANDLED or %FALSE to let
other signal handlers run.
NOTE: GLIB related asan heap-buffer-overflow issue is from the
wrong return.
Change-Id: I4db508aafba556406dce63bb0309d55c9f8a4696
Suggested-by: Sangjung Woo <sangjung.woo@samsung.com>
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
| -rw-r--r-- | src/thermal/thermal.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/thermal/thermal.c b/src/thermal/thermal.c index 60440ab..8d8cb85 100644 --- a/src/thermal/thermal.c +++ b/src/thermal/thermal.c @@ -216,7 +216,7 @@ static gboolean dbus_cb_thermal_start(SystemThermal *obj, _E("failed to initialize Thermal Monitor of the daemon " "in dbus callback for a start message\n"); - return FALSE; + return TRUE; } /** |