summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorwansuyoo <wansu.yoo@samsung.com>2019-04-02 18:46:38 +0900
committerwansuyoo <wansu.yoo@samsung.com>2019-04-02 18:46:38 +0900
commit1d5a6b3e6c457f412f2becfb2b97f2dad756b3ad (patch)
tree38edbf8afc1d6046e811884c0cb1fffaca029934
parent377cdf1aa2e424f43fed850541bcee4afefba1bf (diff)
downloaddocker-launcher-1d5a6b3e6c457f412f2becfb2b97f2dad756b3ad.tar.gz
docker-launcher-1d5a6b3e6c457f412f2becfb2b97f2dad756b3ad.tar.bz2
docker-launcher-1d5a6b3e6c457f412f2becfb2b97f2dad756b3ad.zip
- A pointer to freed memory is dereferenced. - Use of an uninitialized variable. Change-Id: I9287c00aa1417547d57d89e957c36326c4f428d5 Signed-off-by: wansuyoo <wansu.yoo@samsung.com>
-rwxr-xr-xsrc/dzl_dockerctl.c2
-rwxr-xr-xsrc/lib/ipc_client.c1
-rw-r--r--src/lib/yaml_util.c2
3 files changed, 3 insertions, 2 deletions
diff --git a/src/dzl_dockerctl.c b/src/dzl_dockerctl.c
index 2faa9d4..5318b03 100755
--- a/src/dzl_dockerctl.c
+++ b/src/dzl_dockerctl.c
@@ -752,6 +752,7 @@ static char *__generate_dockerd_env(void)
cmd_len += strlen(http_proxy);
}
free(ret_str);
+ ret_str = NULL;
}
ret = __CLI_command(GET_HTTPS_PROXY_CMD, 1, &ret_str);
if (ret_str != NULL) {
@@ -760,6 +761,7 @@ static char *__generate_dockerd_env(void)
cmd_len += strlen(https_proxy);
}
free(ret_str);
+ ret_str = NULL;
}
if (cmd_len > 0) {
diff --git a/src/lib/ipc_client.c b/src/lib/ipc_client.c
index 230d8b2..75027a5 100755
--- a/src/lib/ipc_client.c
+++ b/src/lib/ipc_client.c
@@ -34,7 +34,6 @@ static int __client_open_connection(char *server, SOCKET_HANDLE* phndl)
printf("<<Client>> __client_open_connection\n");
ret = IPC_OpenClientConnection(server, phndl);
if (0 == ret) {
- printf("<<Client>> phndl->server_h = %d\n", phndl->server_h);
printf("<<Client>> phndl->client_h = %d\n", phndl->client_h);
} else {
printf("<<Client>> connection_init ERROR(%d) !!! {%s}\n", ret, SERVER);
diff --git a/src/lib/yaml_util.c b/src/lib/yaml_util.c
index 06df9a9..e6797c5 100644
--- a/src/lib/yaml_util.c
+++ b/src/lib/yaml_util.c
@@ -25,7 +25,7 @@ int yaml_getContents(char *file_name, char *contentsKey, char **retVal)
int stateYAML = YAML_NO_TOKEN;
char *scalarTokenVal = NULL;
int scalarTokenLen = 0;
- char keyTokenVal[256];
+ char keyTokenVal[256] = {0, };
char retTmp[256];
int retTmpLen;
int blockSequenceCnt = 0;