Fix infinite recursive call for AOD corner case

 The subroutine triggered by lcd_off_procedure() could lead infinite
recursive call. This can happen when the lcd_off_procedure() do not
serve actual DPMS_OFF, remaining display state as DPMS_ON even after
the call.
One of the case is when the clockend signal arrives late. In this
situation, deviced forces to set ambient_state as false, but actual node
of lcd power remains ON. This combination of two state* makes deviced
perceive dpms state as DPMS_ON. As a result, lcd_off_procedure() has
been processed, but deviced still recognize dpms state as DPMS_ON,
triggering recursive call for lcd_off_procedure() to turning off display.
 [*] ambient_state=>false && lcd node=>ON

Possible callstack of recursive call
 del_state_cond
 -> default_trans
 -> default_action
 -> lcd_off_procedure**
 -> ambient_set_state(true)
 -> pm_lock_internal
 -> proc_condition
 -> proc_condition_lock
 -> proc_change_state
 -> lcd_off_procedure [repeat **]

To fix this, leave ambient_state as it is when clockend arrival is
delayed. This makes deviced perceive DPMS state as DPMS_OFF, and it
won't trigger lcd_off_procedure().

Change-Id: I14ccca1ba7718975752389cd409a775fbfe80ada
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>

1 files changed, 0 insertions, 1 deletions

diff --git a/src/display/ambient-mode.c b/src/display/ambient-mode.c
index dc45e15e..c5128f41 100755
--- a/src/display/ambient-mode.c
+++ b/src/display/ambient-mode.c
@@ -152,7 +152,6 @@ void ambient_check_invalid_state(pid_t pid)
 	 */
 
 	reset_timeout(TIMEOUT_NONE);
-	ambient_set_state(false);
 	lcd_direct_control(DPMS_OFF, NORMAL_MODE);
 
 	broadcast_lcd_off_late(LCD_OFF_LATE_MODE);