From 68d1911e91ae2b0f9f061a06fe9eeaa54b9933fb Mon Sep 17 00:00:00 2001 From: Karol Lewandowski Date: Tue, 19 Feb 2019 13:04:34 +0100 Subject: crash-manager: Fix error checking for pkgmgrinfo*() invocation This commit fixes 'unchecked return value' as reported by coverity. Change-Id: I8c31504fd03826862f85df5ff24d7752a12262e9 --- src/crash-manager/crash-manager.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/crash-manager/crash-manager.c b/src/crash-manager/crash-manager.c index 2627b06..69a463b 100644 --- a/src/crash-manager/crash-manager.c +++ b/src/crash-manager/crash-manager.c @@ -133,13 +133,11 @@ static int appinfo_get_appid_func(pkgmgrinfo_appinfo_h handle, void *user_data) { char *str = NULL; - int ret = PMINFO_R_ERROR; - pkgmgrinfo_appinfo_get_appid(handle, &str); - if (str) { + int ret = pkgmgrinfo_appinfo_get_appid(handle, &str); + if (ret == PMINFO_R_OK && str) (*(char **)user_data) = strdup(str); - ret = PMINFO_R_OK; - } + return ret; } -- cgit v1.2.3