summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMateusz Moscicki <m.moscicki2@partner.samsung.com>2019-10-21 15:04:09 +0200
committerKarol Lewandowski <k.lewandowsk@samsung.com>2019-10-21 13:57:23 +0000
commitca9c3174b9aecbbeaf0df1f6bcce230fdcfba2ad (patch)
tree1214404415539b88996d911688455cb6e999cdfb
parente7e213842689ce85a83853620b72f5090f6f8e73 (diff)
downloadcrash-worker-ca9c3174b9aecbbeaf0df1f6bcce230fdcfba2ad.tar.gz
crash-worker-ca9c3174b9aecbbeaf0df1f6bcce230fdcfba2ad.tar.bz2
crash-worker-ca9c3174b9aecbbeaf0df1f6bcce230fdcfba2ad.zip
Release 5.5.25: Converity fixsubmit/tizen/20191021.135902
This release brings: - Add check if sh_entsize is zero (coverity fix) - Ensure child termination is handled properly in crash-service Change-Id: I91f400d1e747fbd84894d77b6f215fb5efc03635
-rw-r--r--packaging/crash-worker.spec2
-rw-r--r--packaging/crash-worker_system-tests.spec2
-rw-r--r--src/livedumper/core.hpp4
3 files changed, 6 insertions, 2 deletions
diff --git a/packaging/crash-worker.spec b/packaging/crash-worker.spec
index 6ca15f7..e4d58a0 100644
--- a/packaging/crash-worker.spec
+++ b/packaging/crash-worker.spec
@@ -13,7 +13,7 @@
Name: crash-worker
Summary: Crash-manager
-Version: 5.5.24
+Version: 5.5.25
Release: 1
Group: Framework/system
License: Apache-2.0 and BSD
diff --git a/packaging/crash-worker_system-tests.spec b/packaging/crash-worker_system-tests.spec
index e8a56b3..163c147 100644
--- a/packaging/crash-worker_system-tests.spec
+++ b/packaging/crash-worker_system-tests.spec
@@ -8,7 +8,7 @@
Name: crash-worker_system-tests
Summary: Package with binaries and scripts for crash-worker system tests
-Version: 5.5.24
+Version: 5.5.25
Release: 1
Group: Framework/system
License: Apache-2.0 and BSD
diff --git a/src/livedumper/core.hpp b/src/livedumper/core.hpp
index 54bcf9b..2e4a8c4 100644
--- a/src/livedumper/core.hpp
+++ b/src/livedumper/core.hpp
@@ -306,6 +306,10 @@ class Core {
}
sym_data->data = elf_getdata(scn, nullptr);
+ if (sym_data->shdr.sh_entsize == 0) {
+ logger.log_info("sh_entsize is zero for %s", lib.c_str());
+ return nullptr;
+ }
sym_data->count = sym_data->shdr.sh_size / sym_data->shdr.sh_entsize;
return sym_data;