summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMateusz Moscicki <m.moscicki2@partner.samsung.com>2019-02-12 14:48:10 +0100
committerKarol Lewandowski <k.lewandowsk@samsung.com>2019-02-14 15:40:28 +0100
commit330d32ec418d5e4f6fedfeaef36d586b96c0cf11 (patch)
tree44c65303e95036dec727e7ea1baf567859322a7c
parentf1c251b1ebb9e8857438068c4018c56d514e2a7c (diff)
downloadcrash-worker-330d32ec418d5e4f6fedfeaef36d586b96c0cf11.tar.gz
crash-worker-330d32ec418d5e4f6fedfeaef36d586b96c0cf11.tar.bz2
crash-worker-330d32ec418d5e4f6fedfeaef36d586b96c0cf11.zip
Fix allocation size mismatch
Change-Id: Iee761aafd7f7cb63d12acc48345519faba821536
-rw-r--r--src/crash-manager/so-info.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/crash-manager/so-info.c b/src/crash-manager/so-info.c
index 554edc4..cab1398 100644
--- a/src/crash-manager/so-info.c
+++ b/src/crash-manager/so-info.c
@@ -313,12 +313,6 @@ GSList* create_tpk_list(rpmts ts)
strcmp(&file_name[file_name_len-4], ".tpk") != 0)
continue;
- struct rpm_file *rpm = (struct rpm_file*)malloc(sizeof(rpm));
- if (rpm == NULL) {
- _E("malloc() error (%m). Report (*.so_info) may be incomplete.");
- continue;
- }
-
const char *version = headerGetString(h, RPMTAG_VERSION);
const char *release = headerGetString(h, RPMTAG_RELEASE);
const char *arch = headerGetString(h, RPMTAG_ARCH);
@@ -326,6 +320,12 @@ GSList* create_tpk_list(rpmts ts)
if (version == NULL || release == NULL || arch == NULL)
continue;
+ struct rpm_file *rpm = (struct rpm_file*)malloc(sizeof(*rpm));
+ if (rpm == NULL) {
+ _E("malloc() error (%m). Report (*.so_info) may be incomplete.");
+ continue;
+ }
+
if (asprintf(&rpm->pkg_name, "%s;%s;%s;%s",
pkg_name, version, release, arch) == -1) {
_E("asprintf() error: %m");