diff options
| author | Karol Lewandowski <k.lewandowsk@samsung.com> | 2020-05-21 12:48:30 +0200 |
|---|---|---|
| committer | Karol Lewandowski <k.lewandowsk@samsung.com> | 2020-05-21 14:38:21 +0200 |
| commit | 437dfed641c3199deede83e94618f9e9d55e7836 (patch) | |
| tree | ee1e8f458907f6ae68b65ad1e53892a644137ea3 | |
| parent | 15e5e3d2bb1fc231b66d2ac28b6e8043818ddf15 (diff) | |
| download | crash-worker-437dfed641c3199deede83e94618f9e9d55e7836.tar.gz crash-worker-437dfed641c3199deede83e94618f9e9d55e7836.tar.bz2 crash-worker-437dfed641c3199deede83e94618f9e9d55e7836.zip | |
Clarify logs related to coredump handling
The coredump should not be created when minicoredumper (-s) works
correctly. Make this clear in code and logs.
Change-Id: I2e4e160a46ac4be25143f310ffc336b121530cc8
| -rw-r--r-- | src/crash-manager/crash-manager.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/crash-manager/crash-manager.c b/src/crash-manager/crash-manager.c index 42044be..bb01ee2 100644 --- a/src/crash-manager/crash-manager.c +++ b/src/crash-manager/crash-manager.c @@ -702,12 +702,9 @@ static bool execute_minicoredump(struct crash_info *cinfo, int *exit_code) /* Minicoredumper must be executed to dump at least PRSTATUS for other tools, coredump, however, might have been disabled. */ if (!config.dump_core && file_exists_in_dir(cinfo->pfx, coredump_name)) { + _E("Saving core disabled but coredump found (minicoredumper bug?). Removing coredump %s/%s", cinfo->pfx, coredump_name); if (!remove_file_in_dir(cinfo->pfx, coredump_name)) - _E("Saving core disabled - removing coredump %s/%s failed: %m", - cinfo->pfx, coredump_name); - else - _D("Saving core disabled - removed coredump %s/%s", - cinfo->pfx, coredump_name); + _E("Removing coredump %s/%s failed: %m", cinfo->pfx, coredump_name); } out: |