diff options
| author | Kyungwook Tak <k.tak@samsung.com> | 2016-07-18 11:28:53 +0900 |
|---|---|---|
| committer | Kyungwook Tak <k.tak@samsung.com> | 2016-07-18 13:54:57 +0900 |
| commit | f72179753846682e783bbc4dbe1a3a570e7fac23 (patch) | |
| tree | 792927dbc3307914f6f45b24a1f3a019e5166c9b /tests | |
| parent | 25dec26957850ba42687ffff35fc226039405654 (diff) | |
| download | libwebappenc-f72179753846682e783bbc4dbe1a3a570e7fac23.tar.gz libwebappenc-f72179753846682e783bbc4dbe1a3a570e7fac23.tar.bz2 libwebappenc-f72179753846682e783bbc4dbe1a3a570e7fac23.zip | |
Fix C code naming rules & minor fixes
- Remove some goto label which isn't needed
- Change 'num' param of strncmp / strncpy with meaningful value
(static buffer's size)
- Add const to unsigned char array input param
- Change param names (c string array and raw buffer array)
const char *pPkgId -> pkgId
unsigned char *pDek -> dek
unsigned char **ppDek -> pDek
- Change all camel naminges to underbar
- Remove null checking before call free()
free() does nothing if ptr is null pointer.
(refer: http://linux.die.net/man/3/free)
- Add missing closedir() after opendir()
Change-Id: I7e5888ed3dc77e5355cfc441f10dc0d6d916921c
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/internals.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/internals.cpp b/tests/internals.cpp index 5d6ca2c..257447b 100644 --- a/tests/internals.cpp +++ b/tests/internals.cpp @@ -160,7 +160,7 @@ BOOST_AUTO_TEST_CASE(cache) _add_app_dek_to_cache(pkg3, dek3.data()); size_t dek_len = 32; - unsigned char *_cached = _get_app_dek_from_cache(pkg1); + const unsigned char *_cached = _get_app_dek_from_cache(pkg1); auto cached = Wae::Test::bytearr_to_vec(_cached, dek_len); BOOST_REQUIRE_MESSAGE(cached == dek1, |