diff options
| author | Jeongmo Yang <jm80.yang@samsung.com> | 2017-08-01 14:07:18 +0900 |
|---|---|---|
| committer | Jeongmo Yang <jm80.yang@samsung.com> | 2017-08-01 14:07:18 +0900 |
| commit | f323b7df82f73fa8f962efc10e1a5bf6d9c97266 (patch) | |
| tree | 01ca0f54c64f074cce068bf5483c513810e22065 | |
| parent | 3c97a336814b681ab84ecb63452639279ac5af90 (diff) | |
| download | mmsvc-recorder-accepted/tizen_3.0_common.tar.gz mmsvc-recorder-accepted/tizen_3.0_common.tar.bz2 mmsvc-recorder-accepted/tizen_3.0_common.zip | |
Fix Svace issues - INVARIANT_RESULT.OP_ZERO, SIZEOF_POINTER_TYPEsubmit/tizen_3.0/20170807.093501accepted/tizen/3.0/tv/20170808.070853accepted/tizen/3.0/mobile/20170808.070846accepted/tizen/3.0/ivi/20170808.070905accepted/tizen/3.0/common/20170808.135602tizen_3.0accepted/tizen_3.0_tvaccepted/tizen_3.0_mobileaccepted/tizen_3.0_iviaccepted/tizen_3.0_common
[Version] 0.2.37
[Profile] Common
[Issue Type] Svace
[Dependency module] N/A
Change-Id: Ibe47c7d96a67d8350ffaef2e297ebdbb49dcba5a
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
| -rw-r--r-- | legacy/src/legacy_recorder.c | 6 | ||||
| -rw-r--r-- | legacy/src/legacy_recorder_internal.c | 2 | ||||
| -rw-r--r-- | muse/src/muse_recorder_dispatcher.c | 2 | ||||
| -rw-r--r-- | packaging/mmsvc-recorder.spec | 4 |
4 files changed, 7 insertions, 7 deletions
diff --git a/legacy/src/legacy_recorder.c b/legacy/src/legacy_recorder.c index 3c145b8..1716217 100644 --- a/legacy/src/legacy_recorder.c +++ b/legacy/src/legacy_recorder.c @@ -1045,7 +1045,7 @@ int legacy_recorder_set_file_format(recorder_h recorder, recorder_file_format_e MM_FILE_FORMAT_M2TS /* RECORDER_FILE_FORMAT_M2TS */ }; - if (format < RECORDER_FILE_FORMAT_3GP || format > RECORDER_FILE_FORMAT_M2TS) { + if (format > RECORDER_FILE_FORMAT_M2TS) { LOGE("invalid format %d", format); return RECORDER_ERROR_INVALID_PARAMETER; } @@ -1438,7 +1438,7 @@ int legacy_recorder_attr_set_time_limit(recorder_h recorder, int second) int legacy_recorder_attr_set_audio_device(recorder_h recorder, recorder_audio_device_e device) { - if (device < RECORDER_AUDIO_DEVICE_MIC || device > RECORDER_AUDIO_DEVICE_MODEM) { + if (device > RECORDER_AUDIO_DEVICE_MODEM) { LOGE("invalid device %d", device); return RECORDER_ERROR_INVALID_PARAMETER; } @@ -1548,7 +1548,7 @@ int legacy_recorder_set_video_encoder(recorder_h recorder, recorder_video_codec_ return RECORDER_ERROR_NOT_SUPPORTED; } - if (codec < RECORDER_VIDEO_CODEC_H263 || codec > RECORDER_VIDEO_CODEC_THEORA) { + if (codec > RECORDER_VIDEO_CODEC_THEORA) { LOGE("invalid codec %d", codec); return RECORDER_ERROR_INVALID_PARAMETER; } diff --git a/legacy/src/legacy_recorder_internal.c b/legacy/src/legacy_recorder_internal.c index df11a5b..08577ef 100644 --- a/legacy/src/legacy_recorder_internal.c +++ b/legacy/src/legacy_recorder_internal.c @@ -77,7 +77,7 @@ int legacy_recorder_set_gdbus_connection(recorder_h recorder, void *gdbus_connec LOGD("gdbus_connection %p", gdbus_connection); ret = mm_camcorder_set_attributes(handle->mm_handle, NULL, - MMCAM_GDBUS_CONNECTION, gdbus_connection, sizeof(gdbus_connection), + MMCAM_GDBUS_CONNECTION, gdbus_connection, sizeof(*gdbus_connection), NULL); return __convert_recorder_error_code(__func__, ret); diff --git a/muse/src/muse_recorder_dispatcher.c b/muse/src/muse_recorder_dispatcher.c index 97627b2..a49f1ee 100644 --- a/muse/src/muse_recorder_dispatcher.c +++ b/muse/src/muse_recorder_dispatcher.c @@ -2085,7 +2085,7 @@ int recorder_dispatcher_get_device_state(muse_module_h module) muse_recorder_msg_get(recorder_type, muse_core_client_get_msg(module)); - if (recorder_type < RECORDER_TYPE_AUDIO || recorder_type > RECORDER_TYPE_VIDEO) { + if (recorder_type > RECORDER_TYPE_VIDEO) { LOGE("invalid type %d", recorder_type); ret = CAMERA_ERROR_INVALID_PARAMETER; muse_recorder_msg_return(api, class, ret, module); diff --git a/packaging/mmsvc-recorder.spec b/packaging/mmsvc-recorder.spec index bdb779e..f8f4a7c 100644 --- a/packaging/mmsvc-recorder.spec +++ b/packaging/mmsvc-recorder.spec @@ -1,7 +1,7 @@ Name: mmsvc-recorder Summary: A Recorder module for muse server -Version: 0.2.36 -Release: 1 +Version: 0.2.37 +Release: 0 Group: Multimedia/Libraries License: Apache-2.0 Source0: %{name}-%{version}.tar.gz |