From 14a5f633972f49fcc161990a973e6266cb60a97a Mon Sep 17 00:00:00 2001 From: Jaechan Lee Date: Fri, 18 Aug 2017 10:34:14 +0900 Subject: Fixed memory leak during updating album art [Model] Gear Sports [BinType] AP [Customer] OPEN [Issue#] N/A [Request] N/A [Occurrence Version] N/A [Problem] Memory is leaked during playing mp3 files. [Cause & Measure] Cause : Given sample by calling gst_tag_list_get_sample_index should be freed by calling gst_sample_unref. Measure : Fixed memory leak during updating album art. [Checking Method] N/A [Team] MM FRAMEWORK [Developer] JaeChan Lee [Solution company] Samsung [Change Type] Specification change Change-Id: I7ba8ea76acdad3d6c9696f9ee57c75511fbe338e --- src/mm_player_priv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mm_player_priv.c b/src/mm_player_priv.c index 0e8a8b3..93e8b84 100644 --- a/src/mm_player_priv.c +++ b/src/mm_player_priv.c @@ -1784,6 +1784,7 @@ do { \ buffer = gst_sample_get_buffer(sample);\ if (!gst_buffer_map(buffer, &info, GST_MAP_READ)) {\ LOGD("failed to get image data from tag");\ + gst_sample_unref(sample);\ return FALSE;\ } \ SECURE_LOGD("update album cover data : %p, size : %d\n", info.data, info.size);\ @@ -1800,6 +1801,7 @@ do { \ } \ } \ gst_buffer_unmap(buffer, &info);\ + gst_sample_unref(sample);\ } \ } while (0) -- cgit v1.2.3