diff options
author | jiyong.min <jiyong.min@samsung.com> | 2020-02-13 09:10:30 +0900 |
---|---|---|
committer | jiyong.min <jiyong.min@samsung.com> | 2020-02-13 09:10:30 +0900 |
commit | e9d47642c10ad16b86cde275e8b662d9500219e7 (patch) | |
tree | 4a63f1e9e8c9c32a3dca864cb6010e1184dbfaa4 | |
parent | 3a797526b01b5d7c2bdb6d5391038c2040a0baf9 (diff) | |
download | libmm-fileinfo-e9d47642c10ad16b86cde275e8b662d9500219e7.tar.gz libmm-fileinfo-e9d47642c10ad16b86cde275e8b662d9500219e7.tar.bz2 libmm-fileinfo-e9d47642c10ad16b86cde275e8b662d9500219e7.zip |
Replace return value to define instead of hardcoded number
Change-Id: Ia58d2d95a717fc962ef32f6e1c70698f60c35bb8
-rw-r--r-- | formats/ffmpeg/mm_file_format_mp3.c | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/formats/ffmpeg/mm_file_format_mp3.c b/formats/ffmpeg/mm_file_format_mp3.c index 7d2dc4e..d9380d2 100644 --- a/formats/ffmpeg/mm_file_format_mp3.c +++ b/formats/ffmpeg/mm_file_format_mp3.c @@ -137,7 +137,7 @@ int mmfile_format_read_stream_mp3(MMFileFormatContext *formatContext) return MMFILE_FORMAT_FAIL; } - if (mmf_file_mp3_get_stream_info(formatContext->uriFileName, formatContext->privateFormatData) < 0) { + if (MMFILE_FORMAT_SUCCESS != mmf_file_mp3_get_stream_info(formatContext->uriFileName, formatContext->privateFormatData)) { debug_error(DEBUG, "getting stream information is failed"); return MMFILE_FORMAT_FAIL; } @@ -185,7 +185,7 @@ int mmfile_format_read_tag_mp3(MMFileFormatContext *formatContext) return MMFILE_FORMAT_FAIL; } - if (mmf_file_mp3_get_tag_info(formatContext->uriFileName, formatContext->privateFormatData) < 0) { + if (MMFILE_FORMAT_SUCCESS != mmf_file_mp3_get_tag_info(formatContext->uriFileName, formatContext->privateFormatData)) { debug_error(DEBUG, "getting tag information is failed"); return MMFILE_FORMAT_FAIL; } @@ -1025,7 +1025,7 @@ static int mmf_file_mp3_get_tag_info(char *filename, AvFileContentInfo *pInfo) debug_fenter(RELEASE); if (pInfo == NULL || filename == NULL) - return -1; + return MMFILE_FORMAT_FAIL; memset(pInfo, 0x00, sizeof(AvFileContentInfo)); @@ -1037,7 +1037,7 @@ static int mmf_file_mp3_get_tag_info(char *filename, AvFileContentInfo *pInfo) ret = mmfile_open(&hFile, filename, MMFILE_RDONLY); if (ret == MMFILE_UTIL_FAIL) { debug_error(DEBUG, "open failed.\n"); - return -1; + return MMFILE_FORMAT_FAIL; } if (!__AvGetFileSize(hFile, &pInfo->fileLen)) { @@ -1128,12 +1128,12 @@ static int mmf_file_mp3_get_tag_info(char *filename, AvFileContentInfo *pInfo) debug_msg(RELEASE, "UnsyncLyrics : %s\n", pInfo->tagInfo[AV_ID3TAG_UNSYNCLYRICS].value); debug_msg(RELEASE, "SyncLyrics size : %d\n", pInfo->tagInfo[AV_ID3TAG_SYNCLYRICS].length); - return 0; + return MMFILE_FORMAT_SUCCESS; EXCEPTION: debug_error(DEBUG, "Error occured!\n"); mmfile_close(hFile); - return -1; + return MMFILE_FORMAT_FAIL; } /* @@ -1155,7 +1155,7 @@ static int mmf_file_mp3_get_stream_info(char *filename, AvFileContentInfo *pInfo debug_fenter(RELEASE); if (!pInfo || !filename) - return -1; + return MMFILE_FORMAT_FAIL; memset(pInfo, 0x00, sizeof(AvFileContentInfo)); @@ -1167,7 +1167,7 @@ static int mmf_file_mp3_get_stream_info(char *filename, AvFileContentInfo *pInfo ret = mmfile_open(&hFile, filename, MMFILE_RDONLY); if (ret == MMFILE_UTIL_FAIL) { debug_error(DEBUG, "open failed.\n"); - return -1; + return MMFILE_FORMAT_FAIL; } if (!__AvGetFileSize(hFile, &pInfo->fileLen)) { @@ -1292,10 +1292,10 @@ static int mmf_file_mp3_get_stream_info(char *filename, AvFileContentInfo *pInfo debug_msg(RELEASE, "SampleRate : %u\n", pInfo->sampleRate); debug_msg(RELEASE, "Channels : %u\n", pInfo->channels); - return 0; + return MMFILE_FORMAT_SUCCESS; EXCEPTION: debug_error(DEBUG, "Error occured!\n"); mmfile_close(hFile); - return -1; + return MMFILE_FORMAT_FAIL; } |