Fix a couple of noticeable clang static analyzer warnings (#4981)

* Fix a couple of noticeable clang static analyzer warnings

Fixed passing vector by value, lack of default switch case, dead code

Signed-off-by: Alexey Grebenkin <a.grebenkin@samsung.com>

* Correcting for PR comments

* Correcting for more PR comments

2 files changed, 5 insertions, 5 deletions

diff --git a/runtimes/neurun/backend/cpu/kernel/PermuteLayer.cc b/runtimes/neurun/backend/cpu/kernel/PermuteLayer.cc
index 897c716d8..5674a5a40 100644
--- a/runtimes/neurun/backend/cpu/kernel/PermuteLayer.cc
+++ b/runtimes/neurun/backend/cpu/kernel/PermuteLayer.cc
@@ -193,6 +193,9 @@ void PermuteLayer::run()
       // If two different backends using same tensor layout, we need this.
       throw "NYI";
       break;
+    default:
+      throw "NYI";
+      break;
   }
 }
 
diff --git a/runtimes/neurun/frontend/nnapi/memory.cc b/runtimes/neurun/frontend/nnapi/memory.cc
index e28d1dfd4..2afd5b5ff 100644
--- a/runtimes/neurun/frontend/nnapi/memory.cc
+++ b/runtimes/neurun/frontend/nnapi/memory.cc
@@ -30,14 +30,11 @@ int ANeuralNetworksMemory_createFromFd(size_t size, int protect, int fd, size_t
     return ANEURALNETWORKS_UNEXPECTED_NULL;
   }
 
-  // Use unique pointer to avoid memory leak
-  std::unique_ptr<ANeuralNetworksMemory> memory_ptr =
-      nnfw::cpp14::make_unique<ANeuralNetworksMemory>(size, protect, fd, offset);
-  if (memory_ptr == nullptr)
+  *memory = new (std::nothrow) ANeuralNetworksMemory{size, protect, fd, offset};
+  if (*memory == nullptr)
   {
     return ANEURALNETWORKS_OUT_OF_MEMORY;
   }
-  *memory = memory_ptr.release();
 
   return ANEURALNETWORKS_NO_ERROR;
 }