summaryrefslogtreecommitdiff
path: root/docs
diff options
context:
space:
mode:
author오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 <hseok82.oh@samsung.com>2019-08-22 10:39:41 +0900
committer이춘석/On-Device Lab(SR)/Staff Engineer/삼성전자 <chunseok.lee@samsung.com>2019-08-22 10:39:41 +0900
commit57c6b56c78f19e0a3d27910fbc2ecc2e86db5537 (patch)
treef5fb9b326c19bab1703d30a138b60a9d9e0495a1 /docs
parentf4d7ecdbbd74e076fd6245a973687672f02da141 (diff)
downloadnnfw-57c6b56c78f19e0a3d27910fbc2ecc2e86db5537.tar.gz
nnfw-57c6b56c78f19e0a3d27910fbc2ecc2e86db5537.tar.bz2
nnfw-57c6b56c78f19e0a3d27910fbc2ecc2e86db5537.zip
Replace how-to-contribute documentation (#6802)
Replace two how-to-contribute documentation and remove duplication Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
Diffstat (limited to 'docs')
-rw-r--r--docs/HowToContribute.md (renamed from docs/nnfw/HowToContribute.md)10
-rw-r--r--docs/nncc/contribution_guide.md57
2 files changed, 2 insertions, 65 deletions
diff --git a/docs/nnfw/HowToContribute.md b/docs/HowToContribute.md
index a685c8e46..c6f89c3cf 100644
--- a/docs/nnfw/HowToContribute.md
+++ b/docs/HowToContribute.md
@@ -19,8 +19,8 @@ This section explains the steps to create a pull request (PR).
1. Create an issue
- Maintainers will accept your contribution only when it is well aligned with the [roadmap and
- design principles](./roadmap.md) of _nnfw_. So, it is optional, but recommended for contributors
+ Maintainers will accept your contribution only when it is well aligned with the roadmap and
+ design principles of [_nnfw_](./nnfw/roadmap.md) and [_nncc_](./nncc/roadmap.md). So, it is optional, but recommended for contributors
to create an issue and have a discussion with maintainers before writing code.
1. Create a draft PR
@@ -70,9 +70,3 @@ This section explains the steps to create a pull request (PR).
your pull request upon such feedbacks. These update commits will be squashed into the first
commit of your pull request later. Please do **NOT** include a sign-off message or write a full
description for update commits.
-
-
-# Note
-
-This document is originated from the [contribution guide in
-nncc](https://github.sec.samsung.net/STAR/nncc/blob/master/doc/contribution_guide.md).
diff --git a/docs/nncc/contribution_guide.md b/docs/nncc/contribution_guide.md
deleted file mode 100644
index 44806a012..000000000
--- a/docs/nncc/contribution_guide.md
+++ /dev/null
@@ -1,57 +0,0 @@
-_nncc_ always welcomes your contribution, but there are basic guidelines that you should follow
-in order to make your contribution be accepted.
-
-This document explains such guidelines for beginners.
-
-### HOWTO
-#### How to create a Pull Request
-
-This section explains the steps to create a pull request (PR).
-
-1. Create an issue
-
- Maintainers will accept your contribution only when it is well aligned with the roadmap and design
-principles of _nncc_. So, it is optional, but recommended for contributors to create an issue and have
-a discussion with maintainers before writing code.
-
-1. Create a draft PR
-
- Maintainers will accept your pull request only when it is **reasonably small** and **focused**.
-Sometimes, your contribution may require huge and loosely-coupled changes. You **should** split your
-contribution into multiple small, but focused pull requests in this case. Unfortunately, it is possible
-that maintainers reject your pull request as it is hard for them to understand the intuition behind
-these changes. So, it is optional, but recommended for contributors to present the full draft of your
-contribution and have a discussion with maintainers before creating PR(s).
-
-1. Create a commit
-
- It is time to create a commit for submission once you are convinced that your contribution is ready
-to go. Please include signed-off message at the end of commit message. If not, your pull request will
-be **rejected** by CI.
-
-1. Check code format locally
-
- _nncc_ has its code formatting rules, and any pull request that violates these rules will be
-**rejected** by CI. So, it is optional, but recommended for contributor to check code format locally
-before submission.
-
-1. Create a PR
-
- It is time to send a pull request. Please explain your intention via descrpition. Maintainers will
-review your pull request based on that description. Each pull request needs approval from at least two
-reviewers to be accepted. Note that **description should include at least four words**. If not, your
-pull request will be **rejected** by CI.
-
-1. Request review
-
- Please assign reviewers if you need review from them. Maintainers will honor your review request,
-and accept your pull request only when all the reviewer approve your pull request. Note that this does
-**NOT** mean that you should assign reviewers. Maintainers (or reviewers) will review your pull request
-even without explicit review request.
-
-1. Update per feedback
-
- Sometimes, maintainers (or reviewers) will request changes on your pull request. Please update your
-pull request upon such feedbacks. These update commits will be squashed into the first commit of your
-pull request later. Please do **NOT** include a sign-off message or write a full description for
-update commits.