summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyeonghun Lee <kh9090.lee@samsung.com>2016-12-06 16:27:28 +0900
committerKyeonghun Lee <kh9090.lee@samsung.com>2016-12-06 16:27:28 +0900
commit069f5e2c4cc2a9bbd06c357a34bc203a3c8df53e (patch)
tree91b35b2011fbd40513d23a41b2938b8e1c1c2c46
parent400fe8099cbe736a5b7df91a2fba9df0fa89e8e7 (diff)
downloadmsg-service-069f5e2c4cc2a9bbd06c357a34bc203a3c8df53e.tar.gz
msg-service-069f5e2c4cc2a9bbd06c357a34bc203a3c8df53e.tar.bz2
msg-service-069f5e2c4cc2a9bbd06c357a34bc203a3c8df53e.zip
fix svace issues
Change-Id: I9f465597bce48cb6e5b57fe6f34ba3b704780993 Signed-off-by: Kyeonghun Lee <kh9090.lee@samsung.com>
-rwxr-xr-xplugin/mms_plugin/MmsPluginAppBase.cpp3
-rwxr-xr-xplugin/mms_plugin/MmsPluginStorage.cpp1
-rwxr-xr-xvobject-engine/VMessage.c17
3 files changed, 11 insertions, 10 deletions
diff --git a/plugin/mms_plugin/MmsPluginAppBase.cpp b/plugin/mms_plugin/MmsPluginAppBase.cpp
index ba1b6c3..fa88de6 100755
--- a/plugin/mms_plugin/MmsPluginAppBase.cpp
+++ b/plugin/mms_plugin/MmsPluginAppBase.cpp
@@ -67,9 +67,6 @@ void MmsPluginAppBase::getFirstPageTextFilePath(char *textBuf, int textBufSize)
MMS_MESSAGE_DATA_S *pMmsMsgData = &mmsMsgData;
- if (pMmsMsgData == NULL)
- return;
-
/* Get the text data from the 1st slide. */
if (pMmsMsgData->pageCnt > 0) {
pPage = _MsgMmsGetPage(pMmsMsgData, 0);
diff --git a/plugin/mms_plugin/MmsPluginStorage.cpp b/plugin/mms_plugin/MmsPluginStorage.cpp
index ab8595e..9b01f38 100755
--- a/plugin/mms_plugin/MmsPluginStorage.cpp
+++ b/plugin/mms_plugin/MmsPluginStorage.cpp
@@ -1523,6 +1523,7 @@ msg_error_t MmsPluginStorage::getMessage(MSG_MESSAGE_INFO_S *pMsg, MSG_SENDINGOP
pMsg->dataSize = mmsDataSize;
} else {
MSG_ERR("MsgSerializeMms fail");
+ err = MSG_ERR_MEMORY_ERROR;
}
} else {
diff --git a/vobject-engine/VMessage.c b/vobject-engine/VMessage.c
index 2e0aeef..04caf0c 100755
--- a/vobject-engine/VMessage.c
+++ b/vobject-engine/VMessage.c
@@ -869,7 +869,8 @@ VTree* vmsg_decode(char *pMsgRaw)
pVBody->pTop = NULL;
pVBody->pCur = NULL;
pVBody->pNext = NULL;
- pCurrent->pNext = pVBody;
+ if (pCurrent)
+ pCurrent->pNext = pVBody;
pCurrent = pVBody;
}
}
@@ -908,12 +909,14 @@ VTree* vmsg_decode(char *pMsgRaw)
memset(pTemp, 0, sizeof(VObject));
pTemp->property = type;
- if (pCurrent->pTop == NULL) {
- pCurrent->pTop = pTemp;
- pCurrent->pCur = pTemp;
- } else {
- pCurrent->pCur->pSibling = pTemp;
- pCurrent->pCur = pTemp;
+ if (pCurrent) {
+ if (pCurrent->pTop == NULL) {
+ pCurrent->pTop = pTemp;
+ pCurrent->pCur = pTemp;
+ } else {
+ pCurrent->pCur->pSibling = pTemp;
+ pCurrent->pCur = pTemp;
+ }
}
break;