summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrandeep singh <randeep.s@samsung.com>2018-11-16 05:02:59 +0000
committerGerrit Code Review <gerrit@review.ap-northeast-2.compute.internal>2018-11-16 05:02:59 +0000
commit5dc4f8a3d8e7a83451b3ec9a825285792edaa5c2 (patch)
treee250534b1ee0d88e5b86c7dd95d0de6d11150c32
parentc0198136a556a92b44fbe9d288e4e81387c5f185 (diff)
parent0af19bdc3441509806a32e92ccb77d9bccd5d4d0 (diff)
downloadmsg-service-5dc4f8a3d8e7a83451b3ec9a825285792edaa5c2.tar.gz
msg-service-5dc4f8a3d8e7a83451b3ec9a825285792edaa5c2.tar.bz2
msg-service-5dc4f8a3d8e7a83451b3ec9a825285792edaa5c2.zip
Merge "Resolved coverity isssues" into tizensubmit/tizen/20181116.094538accepted/tizen/unified/20181116.184554
-rwxr-xr-xframework/deliver-handler/MsgDeliverHandler.cpp3
-rw-r--r--manager/src/msg-manager-notification.cpp6
2 files changed, 7 insertions, 2 deletions
diff --git a/framework/deliver-handler/MsgDeliverHandler.cpp b/framework/deliver-handler/MsgDeliverHandler.cpp
index c87d802..0ffeca5 100755
--- a/framework/deliver-handler/MsgDeliverHandler.cpp
+++ b/framework/deliver-handler/MsgDeliverHandler.cpp
@@ -248,7 +248,8 @@ msg_error_t MsgHandleIncomingMsg(MSG_MESSAGE_INFO_S *pMsgInfo, bool *pSendNoti)
}
int activated_conv_id = -1;
- MsgSettingGetInt(VCONFKEY_MESSAGE_ACTIVATED_CONVERSATION_ID, &activated_conv_id);
+ if (MsgSettingGetInt(VCONFKEY_MESSAGE_ACTIVATED_CONVERSATION_ID, &activated_conv_id) != MSG_SUCCESS)
+ MSG_ERR("MsgSettingGetInt() is failed");
if (activated_conv_id > 0 && (unsigned int)activated_conv_id == pMsgInfo->threadId) {
MSG_WARN("Update message read status of current activated thread. [%d]", pMsgInfo->threadId);
diff --git a/manager/src/msg-manager-notification.cpp b/manager/src/msg-manager-notification.cpp
index 909a0d6..3a9ec57 100644
--- a/manager/src/msg-manager-notification.cpp
+++ b/manager/src/msg-manager-notification.cpp
@@ -1374,7 +1374,11 @@ int MsgMgrInsertDeliveryReportInstantNotification(msg_mgr_notification_type_t no
MSG_MGR_BEGIN();
notification_h noti = notification_create(NOTIFICATION_TYPE_NOTI);
- notification_set_pkgname(noti, _get_app_id());
+ int noti_err = notification_set_pkgname(noti, _get_app_id());
+
+ if(noti_err != NOTIFICATION_ERROR_NONE){
+ MSG_MGR_ERR("Fail to notification_set_pkgname : %d", noti_err);
+ }
setTextDomain(noti);
setNotiText(noti, NOTIFICATION_TEXT_TYPE_TITLE, "Delivery report", DELIVERY_MESSAGE);