summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrandeep singh <randeep.s@samsung.com>2018-11-16 05:03:09 +0000
committerGerrit Code Review <gerrit@review.ap-northeast-2.compute.internal>2018-11-16 05:03:09 +0000
commit096bda73775f5389b393f4029f5d14fccf0ac448 (patch)
tree61179d92298d0ef613adbc18e4c16ffdd846a5a4
parent70fb9a14f2060880971147ca0a0be2520bcce207 (diff)
parentf85a03a3f8aa53d61e8d89cf0f9b1a0649391295 (diff)
downloademail-service-096bda73775f5389b393f4029f5d14fccf0ac448.tar.gz
email-service-096bda73775f5389b393f4029f5d14fccf0ac448.tar.bz2
email-service-096bda73775f5389b393f4029f5d14fccf0ac448.zip
Merge "resolved email-service coverity issues" into tizensubmit/tizen/20181116.094658accepted/tizen/unified/20181116.184559
-rwxr-xr-xemail-core/email-core-gmime.c2
-rwxr-xr-xemail-core/email-core-utils.c7
-rw-r--r--email-daemon/email-daemon-event.c4
3 files changed, 9 insertions, 4 deletions
diff --git a/email-core/email-core-gmime.c b/email-core/email-core-gmime.c
index 4aa9d47..c778881 100755
--- a/email-core/email-core-gmime.c
+++ b/email-core/email-core-gmime.c
@@ -910,7 +910,7 @@ static void emcore_gmime_eml_parse_foreach_cb(GMimeObject *parent, GMimeObject *
g_mime_message_foreach(message, emcore_gmime_eml_parse_foreach_cb, temp_cnt_info);
- save_status = temp_cnt_info->text.plain_save_status;
+ //save_status = temp_cnt_info->text.plain_save_status;
save_status = temp_cnt_info->text.html_save_status;
for (ai = temp_cnt_info->file; ai; ai = ai->next) {
diff --git a/email-core/email-core-utils.c b/email-core/email-core-utils.c
index ac20679..2e1f5d6 100755
--- a/email-core/email-core-utils.c
+++ b/email-core/email-core-utils.c
@@ -4315,7 +4315,7 @@ static int emcore_get_next_peak_start_time(emstorage_account_tbl_t *input_accoun
time_info->tm_mday += day_count; /* The other members of time_info will be interpreted or set by mktime */
time_info->tm_hour = input_account_ref->peak_start_time / 100;
- time_info->tm_min = input_account_ref->peak_start_time % 100;
+ //time_info->tm_min = input_account_ref->peak_start_time % 100;
time_info->tm_min = 0;
*output_time = mktime(time_info);
@@ -4397,7 +4397,10 @@ INTERNAL_FUNC int emcore_calc_next_time_to_sync(char *multi_user_name, int input
time_t result_time = 0;
int is_time_in_peak_schedule = 0;
- emstorage_get_account_by_id(multi_user_name, input_account_id, EMAIL_ACC_GET_OPT_DEFAULT, &account, true, &err);
+ if(!emstorage_get_account_by_id(multi_user_name, input_account_id, EMAIL_ACC_GET_OPT_DEFAULT, &account, true, &err)){
+ EM_DEBUG_EXCEPTION("emstorage_get_account_by_id failed [%d]", err);
+ goto FINISH_OFF;
+ }
if (account == NULL) {
EM_DEBUG_EXCEPTION("emstorage_get_account_by_id failed [%d]", err);
goto FINISH_OFF;
diff --git a/email-daemon/email-daemon-event.c b/email-daemon/email-daemon-event.c
index e973dfb..e8b190d 100644
--- a/email-daemon/email-daemon-event.c
+++ b/email-daemon/email-daemon-event.c
@@ -1405,7 +1405,9 @@ static int event_handler_EMAIL_EVENT_DOWNLOAD_ATTACHMENT(char *multi_user_name,
if (!emnetwork_check_network_status(&err)) {
EM_DEBUG_EXCEPTION("emnetwork_check_network_status failed [%d]", err);
- emcore_notify_network_event(NOTI_DOWNLOAD_ATTACH_FAIL, mail_id, NULL, attachment_no, err);
+ if(!emcore_notify_network_event(NOTI_DOWNLOAD_ATTACH_FAIL, mail_id, NULL, attachment_no, err)){
+ EM_DEBUG_EXCEPTION("emcore_notify_network_event[NOTI_DOWNLOAD_ATTACH_FAIL] Failed >>>>");
+ }
} else {
#ifdef __ATTACHMENT_OPTI__
if (!emcore_download_attachment_bulk(account_id, mail_id, attachment_no, handle_to_be_published, &err))