summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-04-07Add widget db busy handlersubmit/tizen_3.0/20170407.104830accepted/tizen/3.0/wearable/20170410.023139accepted/tizen/3.0/tv/20170410.022943accepted/tizen/3.0/mobile/20170410.022710accepted/tizen/3.0/ivi/20170410.023254accepted/tizen/3.0/common/20170410.142619Hwankyu Jhun1-0/+22
While some process is writing on the widget db, the widget parser plugin fails query with SQLITE_BUSY error. This patch is to fix this issue. Change-Id: I4ed4782656bf6585c3bf6d7389405e23010dcbd2 Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2017-03-19Add a new enum value for widget create aborted eventsubmit/tizen_3.0/20170320.054511accepted/tizen/3.0/wearable/20170320.220648accepted/tizen/3.0/tv/20170320.220545accepted/tizen/3.0/mobile/20170320.220447accepted/tizen/3.0/ivi/20170320.220758accepted/tizen/3.0/common/20170321.122719Hwankyu Jhun1-0/+1
Requires: - https://review.tizen.org/gerrit/#/c/119476/ Change-Id: I2391a3ed0325c45cba1c446e5449201645f8a60d Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com> (cherry picked from commit e6694abfdcba3444d87223fc648610a29ebcc665)
2017-03-10Fix memory leaksubmit/tizen_3.0/20170316.021307accepted/tizen/3.0/wearable/20170316.083333accepted/tizen/3.0/tv/20170316.083325accepted/tizen/3.0/mobile/20170316.083309accepted/tizen/3.0/ivi/20170316.083344accepted/tizen/3.0/common/20170316.121720Hwankyu Jhun1-0/+2
Change-Id: I3c20bfa818cc195b2ec78d6a3de17fb70b65180b Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com> (cherry picked from commit 6e8c45268b485577001e028c1ebf9e6a4f5f2986)
2017-03-07Set NULL for appcom handlesubmit/tizen_3.0/20170308.052548Hyunho Kang1-0/+2
aul_app_com_leave can not guarantee appcom handle is NULL Change-Id: Ia4bc3974eb1784fd0eab55b8928575fc1ed653c2 Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com> (cherry picked from commit ad6cc276fe1511c154074fd97a3ff79d3dabd869)
2017-01-30Fix errata in doxygen commentsubmit/tizen_3.0/20170131.015755accepted/tizen/3.0/wearable/20170131.035657accepted/tizen/3.0/tv/20170131.035652accepted/tizen/3.0/mobile/20170131.035648accepted/tizen/3.0/ivi/20170131.035701accepted/tizen/3.0/common/20170131.161810tizen_3.0_tvSemun Lee1-1/+1
Change-Id: I545d9731db74a462e09b9a2d626751012a5c1230 Signed-off-by: Semun Lee <sm79.lee@samsung.com>
2017-01-24Release version 1.2.1submit/tizen_3.0/20170125.045517accepted/tizen/3.0/wearable/20170125.084543accepted/tizen/3.0/tv/20170125.084528accepted/tizen/3.0/mobile/20170125.084502accepted/tizen/3.0/ivi/20170125.084601accepted/tizen/3.0/common/20170125.122028Hwankyu Jhun1-1/+1
Changes: - Fix memory leak Change-Id: I6cbeec8024bc8350db8460ce0e961f27887833fe Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2017-01-24Fix memory leakHwankyu Jhun2-4/+34
Change-Id: I4fe31da58dcee7baa4f3029470d37749a3a8de71 Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2017-01-11Fix bug about setting debug argssubmit/tizen_3.0/20170111.022947submit/tizen/20170111.041200accepted/tizen/wearable/20170111.221947accepted/tizen/tv/20170111.221925accepted/tizen/mobile/20170111.221851accepted/tizen/ivi/20170111.222011accepted/tizen/common/20170112.174208accepted/tizen/3.0/wearable/20170111.090448accepted/tizen/3.0/tv/20170111.090434accepted/tizen/3.0/mobile/20170111.090309accepted/tizen/3.0/ivi/20170111.090503accepted/tizen/3.0/common/20170111.161947Hwankyu Jhun1-54/+112
Change-Id: Ia93adb77ce443948fddc5ca6b031b1f27eeca761 Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2017-01-09Fix widget_service_get_icon bugsubmit/tizen_3.0/20170109.003313submit/tizen_3.0.m2/20170109.005227accepted/tizen/3.0/wearable/20170109.074226accepted/tizen/3.0/tv/20170109.074207accepted/tizen/3.0/mobile/20170109.074147accepted/tizen/3.0/ivi/20170109.074242accepted/tizen/3.0/common/20170109.200423accepted/tizen/3.0.m2/wearable/20170110.084115accepted/tizen/3.0.m2/tv/20170110.084104accepted/tizen/3.0.m2/mobile/20170110.084052accepted/tizen/3.0.m2/common/20170110.181743tizen_3.0.m2accepted/tizen_3.0.m2_wearableaccepted/tizen_3.0.m2_tvaccepted/tizen_3.0.m2_mobileaccepted/tizen_3.0.m2_commonHyunho Kang1-2/+60
Api should get icon info with pkgid Change-Id: I6de807bcdc57f4b71b8ec8c58292a03b5c1ecfe2 Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-12-19fix API descriptionsubmit/tizen_3.0/20161222.014602submit/tizen_3.0.m2/20170104.093749submit/tizen/20170105.005252accepted/tizen/wearable/20170105.223124accepted/tizen/tv/20170105.223104accepted/tizen/mobile/20170105.223035accepted/tizen/ivi/20170105.223145accepted/tizen/common/20170109.202241accepted/tizen/3.0/wearable/20161226.024745accepted/tizen/3.0/tv/20161226.024732accepted/tizen/3.0/mobile/20161226.024712accepted/tizen/3.0/ivi/20161226.024758accepted/tizen/3.0/common/20161227.101312accepted/tizen/3.0.m2/wearable/20170104.122807accepted/tizen/3.0.m2/tv/20170104.122457accepted/tizen/3.0.m2/mobile/20170104.122159Daehyeon Jung3-254/+288
Change-Id: Ie12f31f8ba570d4ab328f19628aefd9e02e166c4 Signed-off-by: Daehyeon Jung <darrenh.jung@samsung.com>
2016-12-14Merge "Add widget viewer dali in doc header" into tizen_3.0taeyoon1-2/+6
2016-12-14Add widget viewer dali in doc headertaeyoon1-2/+6
Change-Id: Id5b0412a8efa848e0da5fc0b648a934871d23c5e
2016-12-12fix licenseDaehyeon Jung1-1/+1
Change-Id: Ia499499b9a413a9e2fa576125db7b7a37c2af2d1 Signed-off-by: Daehyeon Jung <darrenh.jung@samsung.com>
2016-12-09Refactoring resolution filessubmit/tizen_3.0/20161209.072525accepted/tizen/3.0/wearable/20161212.022728accepted/tizen/3.0/tv/20161212.022656accepted/tizen/3.0/mobile/20161212.022601accepted/tizen/3.0/ivi/20161212.022759accepted/tizen/3.0/common/20161212.060405Hyunho Kang67-4182/+40
- remove .conf.ini file (widget_conf.c is not used anymore) - Add 1440x2560 for tm2 - remove widget_conf related files - remove unused resolution files Change-Id: Idf2a9975af0f0a45ae849a448a16b3de69e5a46d Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-12-05Use launchpad-loader for launching widget appssubmit/tizen_3.0/20161205.131352accepted/tizen/3.0/wearable/20161206.000531accepted/tizen/3.0/tv/20161206.000518accepted/tizen/3.0/mobile/20161206.000500accepted/tizen/3.0/ivi/20161206.000541accepted/tizen/3.0/common/20161206.125859Junghoon Park1-1/+0
Change-Id: I6d0dd3c6388c793221fc7084d37edff023dba727 Signed-off-by: Junghoon Park <jh9216.park@samsung.com>
2016-12-02Change upgrade script numbersubmit/tizen_3.0/20161202.085638accepted/tizen/3.0/wearable/20161204.235815accepted/tizen/3.0/tv/20161204.235749accepted/tizen/3.0/mobile/20161204.235705accepted/tizen/3.0/ivi/20161204.235844accepted/tizen/3.0/common/20161205.091922Hwankyu Jhun2-2/+2
Change-Id: I3536c1a36d886e13c7f1d20d5ef85f563d89ecca Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2016-10-18Fix return value about widget_service_get_content_of_widget_instance()submit/tizen_3.0_common/20161104.104000submit/tizen_3.0/20161028.082423submit/tizen_3.0/20161028.082323submit/tizen_3.0/20161028.062323submit/tizen/20161018.072833accepted/tizen/wearable/20161018.235339accepted/tizen/tv/20161018.235345accepted/tizen/mobile/20161018.235333accepted/tizen/ivi/20161018.235355accepted/tizen/common/20161018.175305accepted/tizen/3.0/wearable/20161028.133659accepted/tizen/3.0/wearable/20161028.122846accepted/tizen/3.0/tv/20161028.133349accepted/tizen/3.0/tv/20161028.122622accepted/tizen/3.0/mobile/20161028.133034accepted/tizen/3.0/mobile/20161028.122340accepted/tizen/3.0/ivi/20161028.133927accepted/tizen/3.0/ivi/20161028.123040accepted/tizen/3.0/common/20161114.105638Hwankyu Jhun1-1/+1
Change-Id: I0cdf0cd12a4ae764aaa170c139a089922bad0c97 Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2016-10-14Fix widget_service_change_period wrong returnHyunho Kang1-0/+2
Change-Id: Ia0dda4d566a96f1c1ea787f21c5c8fab73a4f923 Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-10-14Fix widget_service_get_widget_id APIsubmit/tizen/20161014.000340accepted/tizen/wearable/20161014.005423accepted/tizen/tv/20161014.005408accepted/tizen/mobile/20161014.005350accepted/tizen/ivi/20161014.005441accepted/tizen/common/20161014.043106Hwankyu Jhun5-88/+27
- Add prime column to widget_class table Change-Id: I691ae3b0b0d1dcec5c472aa573a91e7a242cb95e Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2016-10-12Fix widget_service_get_content_of_widget_instance()submit/tizen/20161012.155021accepted/tizen/wearable/20161013.000907accepted/tizen/tv/20161013.000857accepted/tizen/mobile/20161013.000845accepted/tizen/ivi/20161013.000921accepted/tizen/common/20161013.155703Hyunho Kang2-10/+38
- supports content info of outside processes Change-Id: I158894842029af77b29a3e2f38a9b88c66b9bcf9 Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-10-13Fix widget_service_chage_period instance exist logicHyunho Kang3-15/+39
Check instance exist with amd if local check fail Change-Id: I7762d936839e9bb0504ceefcf6858ce5d8e2190d Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-10-11Fix wrong parameter about widget_service_set_lifecycle_event_cb APIsubmit/tizen/20161011.045658accepted/tizen/wearable/20161011.234103accepted/tizen/tv/20161011.234040accepted/tizen/mobile/20161011.234105accepted/tizen/ivi/20161011.234109accepted/tizen/common/20161011.154205Hwankyu Jhun1-1/+2
Change-Id: I7ab0abbd3945d7cf357956695d595528de84b7ec Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2016-10-10Add direct attach gdb/valgrind featuresubmit/tizen/20161010.123514accepted/tizen/wearable/20161011.050255accepted/tizen/tv/20161011.050239accepted/tizen/mobile/20161011.050222accepted/tizen/ivi/20161011.050309accepted/tizen/common/20161010.150103Hyunho Kang2-2/+91
Change-Id: Ib1f75b4dab29321058c66fb0c61a5237e1cd4159 Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-10-07Check the package id in the status handlersubmit/tizen/20161010.043049accepted/tizen/wearable/20161010.083227accepted/tizen/tv/20161010.083213accepted/tizen/mobile/20161010.083155accepted/tizen/ivi/20161010.083245accepted/tizen/common/20161010.145847Hwankyu Jhun1-4/+41
Change-Id: I51a8f2870ba4f1b7c6cba6394b4e72ad2a047f27 Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2016-10-07Fix widget_service_get_widget_id APIHwankyu Jhun1-0/+169
The appid parameter of the widget_service_get_widget_id API can be package id. Change-Id: I8d5e41f1f161a54173b6e9e523bc02bf95f34a9c Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2016-09-26Revert "Fixing build error"Hyunho Kang1-7/+5
This reverts commit 5165f46db2c6f1d97dfb9cb49d0ac057ce425dfd. Change-Id: I98975288c064a23b7345467db6462b4f05413e7a
2016-09-23Fixing build errorsubmit/tizen/20160923.052548accepted/tizen/wearable/20160926.000625accepted/tizen/tv/20160926.000607accepted/tizen/mobile/20160926.000551accepted/tizen/ivi/20160926.000643MyoungJune Park1-5/+7
- iniparser api spec modified Change-Id: I1287de7f8694f02215f8ac747a233e7277954f15 Signed-off-by: MyoungJune Park <mj2004.park@samsung.com>
2016-09-06Implement widget_service_get_instance_countsubmit/tizen_3.0_wearable/20161015.000006submit/tizen_3.0_tv/20161015.000006submit/tizen_3.0_mobile/20161015.000007submit/tizen_3.0_ivi/20161010.000008submit/tizen/20160926.053137submit/tizen/20160908.041324accepted/tizen/wearable/20160926.091530accepted/tizen/wearable/20160909.001656accepted/tizen/tv/20160926.091512accepted/tizen/tv/20160909.001640accepted/tizen/mobile/20160926.091503accepted/tizen/mobile/20160909.001623accepted/tizen/ivi/20160926.091551accepted/tizen/ivi/20160909.001717accepted/tizen/common/20160908.134613accepted/tizen/3.0/wearable/20161015.084425accepted/tizen/3.0/tv/20161016.010002accepted/tizen/3.0/mobile/20161015.034356accepted/tizen/3.0/ivi/20161011.070331Hyunho Kang2-6/+23
Change-Id: If4afe9417708605b024de039ca2e7a0ef2a42e89 Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-09-05Add a script to upgrade widget dbsubmit/tizen/20160905.010800accepted/tizen/wearable/20160905.235846accepted/tizen/tv/20160905.235821accepted/tizen/mobile/20160905.235751accepted/tizen/ivi/20160905.235913accepted/tizen/common/20160905.171443Hwankyu Jhun2-0/+37
Change-Id: Iaaae6502c7a525d9bdee19de74ac6f6160df0fe8 Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2016-08-31Clear db journal file to prevent rebuildHyunho Kang1-0/+2
Change-Id: I935627a2a276130686d398266992b03637d4a11d Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-08-30Fix widget plugin parsersubmit/tizen/20160830.074519accepted/tizen/wearable/20160831.124220accepted/tizen/tv/20160831.124202accepted/tizen/mobile/20160831.124149accepted/tizen/ivi/20160831.124238accepted/tizen/common/20160830.150339Hwankyu Jhun1-14/+31
- Use pkgmgr API to get app root path Change-Id: I5dae1335a88e31c87f1627a090d7c7c9b214acc7 Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2016-08-29Remove aul.h from public headersubmit/tizen/20160829.073018accepted/tizen/wearable/20160830.061234accepted/tizen/tv/20160830.061151accepted/tizen/mobile/20160830.061108accepted/tizen/ivi/20160830.061239accepted/tizen/common/20160830.150013Hyunho Kang1-6/+5
Change-Id: I07fe7724ecaccfa45f3ebd24b2aada140cdc9806 Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-08-23Fix widget_service_get_widget_instance_list API return value descsubmit/tizen/20160829.010716accepted/tizen/common/20160829.140005Hyunho Kang1-2/+4
Change-Id: I30a4a25a4641edcddc70c3b970257d5896d0750f Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-08-22Load resolution info from .ini fileHyunho Kang22-3/+211
Change-Id: I8a2d8d1f4fa958bdc320ee83f8908f940a5ac76b Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-08-09Fix api param descriptionHyunho Kang1-2/+2
- widget_service_get_supported_sizes - widget_service_get_supported_size_types Change-Id: I53b0d53505240d07e752bdff86d75a585fd4f5d5 Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-08-08Fix the description about WIDGET_ERROR_MAX_EXCEEDsubmit/tizen/20160809.051427accepted/tizen/wearable/20160809.232706accepted/tizen/tv/20160809.232500accepted/tizen/mobile/20160809.232343accepted/tizen/ivi/20160809.232611accepted/tizen/common/20160809.183933Hwankyu Jhun1-3/+2
Change-Id: I22a0b71eab545f65167e2fba421d91f7a62c81c8 Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2016-08-07Implement widget_service_get_widget_max_count APIsubmit/tizen/20160809.011327Hwankyu Jhun7-6/+90
Change-Id: I3fb54922e6e9b8a731d672dfce2d24d475fb9d9b Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2016-08-02Fix widget plugin parserHwankyu Jhun3-3/+23
- Use pkgmgr_installer_info_get_target_uid() instead of getuid() - Requires [slp-pkgmgr] https://review.tizen.org/gerrit/#/c/81631/ Change-Id: I003b0c826c3ccb88aeefa612c9ccb1663dcb05e4 Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2016-07-29Add widget app restart logicsubmit/tizen/20160803.012753accepted/tizen/wearable/20160804.080552accepted/tizen/tv/20160804.080720accepted/tizen/mobile/20160804.080854accepted/tizen/ivi/20160804.080804accepted/tizen/common/20160803.193220Hyunho Kang4-46/+101
Change-Id: I705fa5b45ba3809b9e61327730220c292f026139 Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-07-25Merge "Fix widget_service_get_widget_list return value" into tizensubmit/tizen/20160726.020747accepted/tizen/wearable/20160726.063229accepted/tizen/tv/20160726.063211accepted/tizen/mobile/20160726.063157accepted/tizen/ivi/20160726.063249accepted/tizen/common/20160726.080617HwanKyu Jhun1-0/+3
2016-07-25Fix widget_service_get_widget_list return valueDaehyeon Jung1-0/+3
- get_widget_list should return WIDGET_ERROR_NOT_EXIST if 0 app exist Change-Id: Icd0f5d8c701029ad3845455b052718a402360148
2016-07-13Fix coding stylesubmit/tizen/20160714.002239submit/tizen/20160714.000614accepted/tizen/wearable/20160714.053816accepted/tizen/tv/20160714.053800accepted/tizen/mobile/20160714.053744accepted/tizen/ivi/20160714.053828accepted/tizen/common/20160714.152752accepted/tizen/common/20160714.152704Junghoon Park1-1/+1
Change-Id: Ifb7a2e67e76b3d2e17dce981cef678ec09931273 Signed-off-by: Junghoon Park <jh9216.park@samsung.com>
2016-07-12Exclude line and function from coverage measurementsubmit/tizen/20160712.081629accepted/tizen/wearable/20160712.091249accepted/tizen/tv/20160712.091230accepted/tizen/mobile/20160712.091252accepted/tizen/ivi/20160712.091233accepted/tizen/common/20160713.050508Hyunho Kang3-0/+26
Change-Id: Idac4cf86460c00f82f7057c98c35586fa67f1bd0 Signed-off-by: Hyunho Kang <hhstark.kang@samsung.com>
2016-07-12Fix wrong return valueHwankyu Jhun1-1/+1
Change-Id: Id2dc61c561105be696a2da52521cf9a65bcc287c Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2016-07-11Fix widget_service_trigger_updatesubmit/tizen/20160711.130213accepted/tizen/wearable/20160712.000217accepted/tizen/tv/20160712.000208accepted/tizen/mobile/20160712.000110accepted/tizen/ivi/20160712.000228accepted/tizen/common/20160712.150529Daehyeon Jung3-30/+60
- Previously, some widget_service functions that allowed for the application in the same package with target widget application were not supported. - The patch uses aul_widget_instance_* functions to store/load widget_instance informations across the package. Change-Id: If92972d01213049f536fecb6bd4e90f6e90c5f63 Signed-off-by: Daehyeon Jung <darrenh.jung@samsung.com>
2016-06-29fix widget updatesubmit/tizen/20160630.104402accepted/tizen/wearable/20160701.033857accepted/tizen/tv/20160701.033743accepted/tizen/mobile/20160701.033948accepted/tizen/ivi/20160701.033833accepted/tizen/common/20160630.153959Daehyeon Jung3-192/+146
Change-Id: I64a5da93a43e64e26399a851ec4afa2578637c8f Signed-off-by: Daehyeon Jung <darrenh.jung@samsung.com>
2016-06-28Launch widget app with async apisubmit/tizen/20160628.070541accepted/tizen/wearable/20160629.020648accepted/tizen/tv/20160629.020600accepted/tizen/mobile/20160629.020704accepted/tizen/ivi/20160629.020623accepted/tizen/common/20160629.222509Semun Lee1-1/+1
When the widget-viewer launches widget app with sync api, the widget app would be blocked in its elm_win_add function because the widget-viewer is waiting for aul_launch_app api and cannot process request of elm_win_add. Note that this api is a temporary solution. We need to investigate if there is a better solution. Change-Id: I264b5bd3195ad9a204be406705d03eddaa3ed1cc Signed-off-by: Semun Lee <sm79.lee@samsung.com>
2016-06-23remove db operationsubmit/tizen/20160623.082534accepted/tizen/wearable/20160623.125041accepted/tizen/tv/20160623.125018accepted/tizen/mobile/20160623.125008accepted/tizen/ivi/20160623.125059accepted/tizen/common/20160623.154525Daehyeon Jung1-243/+1
Change-Id: I47e7fd97ebf603c13d9e2aff893c2713a7826dae Signed-off-by: Daehyeon Jung <darrenh.jung@samsung.com>
2016-06-17fix uninitialized valuesubmit/tizen/20160617.084427submit/tizen/20160617.065536accepted/tizen/wearable/20160620.024526accepted/tizen/tv/20160620.024512accepted/tizen/mobile/20160620.024449accepted/tizen/ivi/20160620.024547accepted/tizen/common/20160617.122026Daehyeon Jung2-2/+2
Change-Id: I4d28967f2da51aaacede678d91ac8df4da6a170b
2016-06-13Fix crash when preview image is NULLsubmit/tizen/20160613.062107accepted/tizen/wearable/20160614.041138accepted/tizen/tv/20160614.041154accepted/tizen/mobile/20160614.041118accepted/tizen/ivi/20160614.041208accepted/tizen/common/20160614.143656Sangyoon Jang1-6/+11
Change-Id: I2dcb9f19e1a194ae0e731facabffd7072b420f3a Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>