diff options
author | Myungki Lee <mk5004.lee@samsung.com> | 2015-12-21 13:55:50 +0900 |
---|---|---|
committer | Myungki Lee <mk5004.lee@samsung.com> | 2015-12-21 14:06:49 +0900 |
commit | 7acedcdca28c3a2d491c8d9227fcf7e1cca004c1 (patch) | |
tree | 8786800c437576e7f8b83c0f53f65b9b4fd8c835 | |
parent | be6f0dc4328628ce98c47ac970eac113ae9efb6a (diff) | |
download | com-core-accepted/tizen_tv.tar.gz com-core-accepted/tizen_tv.tar.bz2 com-core-accepted/tizen_tv.zip |
specify char variable's signedness qualifiersubmit/tizen_ivi/20160217.000002submit/tizen_ivi/20160217.000000submit/tizen_common/20151229.154718submit/tizen_common/20151229.144031submit/tizen_common/20151229.142028submit/tizen/20151222.052059accepted/tizen/wearable/20151222.090329accepted/tizen/tv/20151222.090310accepted/tizen/mobile/20151222.090248accepted/tizen/ivi/20160218.023312accepted/tizen_wearableaccepted/tizen_tvaccepted/tizen_mobileaccepted/tizen_ivi
Checker detects using of 'char' type variable in conditional expressions.
char without a signedness qualifier (signed or unsigned) can be interpreted as unsigned char,
and it may result in unexpected behavior.
Change-Id: Ie50277993a3145acded84b581f905c28b7ea47c7
Signed-off-by: Myungki Lee <mk5004.lee@samsung.com>
-rw-r--r-- | src/com-core_thread.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/com-core_thread.c b/src/com-core_thread.c index 3bb457f..33e1736 100644 --- a/src/com-core_thread.c +++ b/src/com-core_thread.c @@ -208,7 +208,7 @@ static inline void terminate_thread(struct tcb *tcb) */ static inline void chunk_remove(struct tcb *tcb, struct chunk *chunk) { - char event_ch; + signed char event_ch; /* Consuming the event */ if (read(tcb->evt_pipe[PIPE_READ], &event_ch, sizeof(event_ch)) != sizeof(event_ch)) { @@ -231,7 +231,7 @@ static inline void chunk_remove(struct tcb *tcb, struct chunk *chunk) */ static inline int chunk_append(struct tcb *tcb, struct chunk *chunk) { - char event_ch = EVENT_READY; + signed char event_ch = EVENT_READY; int ret; CRITICAL_SECTION_BEGIN(&tcb->chunk_lock); @@ -344,7 +344,7 @@ static void *client_cb(void *data) int ret = 0; fd_set set; int readsize; - char event_ch; + signed char event_ch; int fd; DbgPrint("Thread is created for %d (server: %d)\n", tcb->handle, tcb->server_handle); |