summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMyungki Lee <mk5004.lee@samsung.com>2015-10-21 19:21:12 +0900
committerMyungki Lee <mk5004.lee@samsung.com>2015-10-21 19:21:12 +0900
commit3f863719e7f13962d3be2836b7a4162a700aa39c (patch)
tree314c92cef66c75d92db0e63380823eb348a222f4
parentf67553b73e485ece3b5d3764e84e3cec98ec20a6 (diff)
downloadaul-1-3f863719e7f13962d3be2836b7a4162a700aa39c.tar.gz
aul-1-3f863719e7f13962d3be2836b7a4162a700aa39c.tar.bz2
aul-1-3f863719e7f13962d3be2836b7a4162a700aa39c.zip
Fix prevent bugs: Uncheck return value, Dead default in switch.
Change-Id: Ie1a4e4d10631d6831381b25f418beb1f3dc055c9 Signed-off-by: Myungki Lee <mk5004.lee@samsung.com>
-rwxr-xr-xsrc/aul_rsc_mgr.c25
1 files changed, 7 insertions, 18 deletions
diff --git a/src/aul_rsc_mgr.c b/src/aul_rsc_mgr.c
index 53ff3ede..add52598 100755
--- a/src/aul_rsc_mgr.c
+++ b/src/aul_rsc_mgr.c
@@ -172,8 +172,12 @@ static bool __get_screen_large(void)
screen_large = false;
} else
screen_large = atoi(tmp);
- } else
- system_info_get_platform_bool("http://tizen.org/feature/screen.size.large", &screen_large);
+ } else {
+ if (system_info_get_platform_bool("http://tizen.org/feature/screen.size.large", &screen_large) != SYSTEM_INFO_ERROR_NONE) {
+ LOGE("Failed to get info of screen.size.large");
+ screen_large = false;
+ }
+ }
return screen_large;
}
@@ -299,9 +303,6 @@ static void __bundle_iterator_get_valid_nodes(const char *key, const int type,
if (strncmp(cur_language, val, strlen(val)))
*invalid = true;
break;
-
- default:
- break;
}
}
@@ -346,9 +347,6 @@ static void __bundle_iterator_get_best_node(const char *key, const char *val,
case NODE_ATTR_LANGUAGE:
*weight += WEIGHT_LANGUAGE;
break;
-
- default:
- break;
}
}
@@ -390,9 +388,6 @@ static const char *__get_cache(aul_resource_e type,
case AUL_RESOURCE_TYPE_BIN:
rsc_type = RSC_GROUP_TYPE_BIN;
break;
-
- default:
- rsc_type = "NULL";
}
}
@@ -518,9 +513,6 @@ static void __put_cache(aul_resource_e type, const char *id,
case AUL_RESOURCE_TYPE_BIN:
rsc_type = RSC_GROUP_TYPE_BIN;
break;
-
- default:
- rsc_type = "NULL";
}
}
@@ -588,9 +580,6 @@ static resource_group_t *__find_group(resource_data_t *data,
case AUL_RESOURCE_TYPE_BIN:
rsc_type = RSC_GROUP_TYPE_BIN;
break;
-
- default:
- rsc_type = "NULL";
}
}
@@ -880,7 +869,7 @@ static int __set_valid_filelist(bundle *b)
if (retval == AUL_RESOURCE_ERROR_NONE)
g_hash_table_add(valid_path_list, path);
else
- LOGD("failed to get value with given type[%d], key[%s]", rsc_type, id_key);
+ LOGE("failed to get value with given type[%d], key[%s]", rsc_type, id_key);
if (cur_language) {
free(cur_language);