Fix memory leaksubmit/tizen_3.0_common/20170508.091735submit/tizen_3.0/20170426.044950submit/tizen_3.0-common/20170508.091535submit/tizen_3.0-common/20170508.081301submit/tizen_3.0-common/20170508.080135accepted/tizen/3.0/wearable/20170508.050428accepted/tizen/3.0/tv/20170508.050410accepted/tizen/3.0/mobile/20170508.050349accepted/tizen/3.0/ivi/20170508.050438accepted/tizen/3.0/common/20170508.153041

- Fix memory leak in sqlite3 error_message
- Add missing sqlite3_stmt in _load_alarms_from_registry

Change-Id: Idbcca3d50d30a0d7848b728cb07cd4ccfdd57879
Signed-off-by: Jiwoong Im <jiwoong.im@samsung.com>

1 files changed, 11 insertions, 2 deletions

diff --git a/alarm-manager.c b/alarm-manager.c
index dbe69c4..2950689 100644
--- a/alarm-manager.c
+++ b/alarm-manager.c
@@ -652,6 +652,7 @@ gboolean __update_relative_alarms(gpointer user_data)
 
 	if (sqlite3_exec(alarmmgr_db, "BEGIN EXCLUSIVE", NULL, NULL, &error_message) != SQLITE_OK) {
 		SECURE_LOGE("sqlite3_exec() is failed. error message = %s", error_message);
+		sqlite3_free(error_message);
 		return false;
 	}
 
@@ -664,6 +665,7 @@ gboolean __update_relative_alarms(gpointer user_data)
 
 	if (sqlite3_exec(alarmmgr_db, "COMMIT", NULL, NULL, &error_message) != SQLITE_OK) {
 		SECURE_LOGE("sqlite3_exec() is failed. error message = %s", error_message);
+		sqlite3_free(error_message);
 		return false;
 	}
 
@@ -1243,6 +1245,7 @@ static bool __alarm_set_global_to_db(__alarm_info_t *alarm_info, bool global)
 	if (SQLITE_OK != sqlite3_exec(alarmmgr_db, query, NULL, NULL, &error_message)) {
 		SECURE_LOGE("sqlite3_exec() is failed. query = %s, error message = %s", query, error_message);
 		sqlite3_free(query);
+		sqlite3_free(error_message);
 		return false;
 	}
 
@@ -3465,12 +3468,16 @@ gboolean alarm_manager_alarm_get_all_info(AlarmManager *pObject, GDBusMethodInvo
 	}
 
 	/* Drop a table */
-	if (sqlite3_exec(alarmmgr_tool_db, query_for_deleting_table, NULL, NULL, &error_message) != SQLITE_OK)
+	if (sqlite3_exec(alarmmgr_tool_db, query_for_deleting_table, NULL, NULL, &error_message) != SQLITE_OK) {
 		ALARM_MGR_EXCEPTION_PRINT("Deleting the table is failed. error message = %s", error_message);
+		sqlite3_free(error_message);
+	}
 
 	/* Create a table if it does not exist */
 	if (sqlite3_exec(alarmmgr_tool_db, query_for_creating_table, NULL, NULL, &error_message) != SQLITE_OK) {
 		ALARM_MGR_EXCEPTION_PRINT("Creating the table is failed. error message = %s", error_message);
+		sqlite3_free(error_message);
+		sqlite3_close(alarmmgr_tool_db);
 		return_code = ERR_ALARM_SYSTEM_FAIL;
 		goto done;
 	}
@@ -3507,8 +3514,10 @@ gboolean alarm_manager_alarm_get_all_info(AlarmManager *pObject, GDBusMethodInvo
 				mode->repeat,
 				entry->alarm_info.alarm_type);
 
-		if (sqlite3_exec(alarmmgr_tool_db, query, NULL, NULL, &error_message) != SQLITE_OK)
+		if (sqlite3_exec(alarmmgr_tool_db, query, NULL, NULL, &error_message) != SQLITE_OK) {
 			SECURE_LOGE("sqlite3_exec() is failed. error message = %s", error_message);
+			sqlite3_free(error_message);
+		}
 
 		sqlite3_free(query);
 	}