diff options
author | Jeongmo Yang <jm80.yang@samsung.com> | 2017-05-15 14:24:23 +0900 |
---|---|---|
committer | Jeongmo Yang <jm80.yang@samsung.com> | 2017-05-15 14:24:23 +0900 |
commit | b436b6ad2e3888eb5dbb61639c18768bb04015eb (patch) | |
tree | c5fd035430b8ce75d0b3d48eb0cda0345a9dc4b9 | |
parent | 15dc716c2e5d163160835e379f03918a1b26e63f (diff) | |
download | recorder-b436b6ad2e3888eb5dbb61639c18768bb04015eb.tar.gz recorder-b436b6ad2e3888eb5dbb61639c18768bb04015eb.tar.bz2 recorder-b436b6ad2e3888eb5dbb61639c18768bb04015eb.zip |
Add comments for line coverage test
[Version] 0.3.0
[Profile] Common
[Issue Type] Update
[Dependency module] N/A
Change-Id: I6037d4beb06a3521249676bf58d32e6813435a3a
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
-rw-r--r-- | CMakeLists.txt | 2 | ||||
-rw-r--r-- | src/recorder.c | 46 |
2 files changed, 45 insertions, 3 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index 746e552..cb0ef32 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -28,7 +28,7 @@ FOREACH(flag ${${fw_name}_CFLAGS}) SET(EXTRA_CFLAGS "${EXTRA_CFLAGS} ${flag}") ENDFOREACH(flag) -SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS} -fPIC -Wall -Wextra -Wno-array-bounds -Wno-empty-body -Wno-ignored-qualifiers -Wno-unused-parameter -Wshadow -Wwrite-strings -Wswitch-default -Wno-unused-but-set-parameter -Wno-unused-but-set-variable") +SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS} -fPIC -Wall -Wextra -Wno-array-bounds -Wno-empty-body -Wno-ignored-qualifiers -Wno-unused-parameter -Wshadow -Wwrite-strings -Wswitch-default -Wno-unused-but-set-parameter -Wno-unused-but-set-variable -fprofile-arcs -ftest-coverage") SET(CMAKE_C_FLAGS_DEBUG "-O0 -g") IF("${ARCH}" STREQUAL "arm") diff --git a/src/recorder.c b/src/recorder.c index 5b0d745..406c198 100644 --- a/src/recorder.c +++ b/src/recorder.c @@ -330,6 +330,7 @@ static void _recorder_client_user_callback(recorder_cb_info_s *cb_info, char *re } break; } +//LCOV_EXCL_START case MUSE_RECORDER_EVENT_TYPE_ERROR: { int error = 0; @@ -350,6 +351,7 @@ static void _recorder_client_user_callback(recorder_cb_info_s *cb_info, char *re cb_info->user_data[event]); break; } +//LCOV_EXCL_STOP case MUSE_RECORDER_EVENT_TYPE_FOREACH_SUPPORTED_AUDIO_ENCODER: { int codec = 0; @@ -938,9 +940,11 @@ static void *_recorder_msg_recv_func(gpointer data) while (g_atomic_int_get(&cb_info->msg_recv_running)) { recv_length = muse_core_ipc_recv_msg(cb_info->fd, recv_msg); if (recv_length <= 0) { +//LCOV_EXCL_START cb_info->is_server_connected = FALSE; LOGE("receive msg failed - server disconnected"); break; +//LCOV_EXCL_STOP } recv_msg[recv_length] = '\0'; @@ -959,6 +963,7 @@ static void *_recorder_msg_recv_func(gpointer data) if (single_length < MUSE_RECORDER_MSG_MAX_LENGTH) { /* check remained msg */ if (remained_length > 0) { +//LCOV_EXCL_START if (remained_msg) { strncpy(single_msg, remained_msg, remained_length); strncpy(single_msg + remained_length, recv_msg + prev_pos, single_length); @@ -973,6 +978,7 @@ static void *_recorder_msg_recv_func(gpointer data) } remained_length = 0; +//LCOV_EXCL_STOP } else { strncpy(single_msg, recv_msg + prev_pos, single_length); single_msg[single_length] = '\0'; @@ -995,6 +1001,7 @@ static void *_recorder_msg_recv_func(gpointer data) /* check incompleted message */ if (recv_msg[recv_length - 1] != '}') { +//LCOV_EXCL_START remained_length = recv_length - prev_pos; LOGW("incompleted message [len %d]", remained_length); @@ -1006,6 +1013,7 @@ static void *_recorder_msg_recv_func(gpointer data) } else { LOGE("failed to alloc for remained msg"); } +//LCOV_EXCL_STOP } else { remained_length = 0; } @@ -1014,6 +1022,7 @@ static void *_recorder_msg_recv_func(gpointer data) LOGD("client cb exit - server connected %d", cb_info->is_server_connected); if (!cb_info->is_server_connected) { +//LCOV_EXCL_START /* send error msg for server disconnection */ char *error_msg = muse_core_msg_json_factory_new(MUSE_RECORDER_CB_EVENT, MUSE_TYPE_INT, "error", RECORDER_ERROR_SERVICE_DISCONNECTED, @@ -1037,6 +1046,7 @@ static void *_recorder_msg_recv_func(gpointer data) error_msg = NULL; LOGE("add error msg for service disconnection done"); +//LCOV_EXCL_STOP } CB_HANDLER_EXIT: @@ -1081,6 +1091,7 @@ static bool __create_msg_handler_thread(recorder_msg_handler_info_s *handler_inf handler_info->thread = g_thread_try_new(thread_name, _recorder_msg_handler_func, (gpointer)handler_info, NULL); if (handler_info->thread == NULL) { +//LCOV_EXCL_START LOGE("t:%d thread failed", type); g_mutex_clear(&handler_info->mutex); @@ -1089,6 +1100,7 @@ static bool __create_msg_handler_thread(recorder_msg_handler_info_s *handler_inf handler_info->queue = NULL; return false; +//LCOV_EXCL_STOP } LOGD("t:%d done", type); @@ -1185,7 +1197,7 @@ static recorder_cb_info_s *_recorder_client_callback_new(gint sockfd) cb_info->is_server_connected = TRUE; return cb_info; - +//LCOV_EXCL_START ErrorExit: if (cb_info) { __destroy_msg_handler_thread(&cb_info->msg_handler_info); @@ -1204,6 +1216,7 @@ ErrorExit: } return NULL; +//LCOV_EXCL_STOP } static int _recorder_client_wait_for_cb_return(muse_recorder_api_e api, recorder_cb_info_s *cb_info, int time_out) @@ -1490,9 +1503,11 @@ static int _recorder_create_common(recorder_h *recorder, muse_recorder_type_e ty sock_fd = muse_core_client_new(); if (sock_fd < 0) { +//LCOV_EXCL_START LOGE("muse_core_client_new failed - returned fd %d", sock_fd); ret = RECORDER_ERROR_INVALID_OPERATION; goto _ERR_RECORDER_EXIT; +//LCOV_EXCL_STOP } if (type == MUSE_RECORDER_TYPE_AUDIO) { @@ -1513,9 +1528,11 @@ static int _recorder_create_common(recorder_h *recorder, muse_recorder_type_e ty } if (!send_msg) { +//LCOV_EXCL_START LOGE("NULL msg"); ret = RECORDER_ERROR_OUT_OF_MEMORY; goto _ERR_RECORDER_EXIT; +//LCOV_EXCL_STOP } LOGD("sock_fd : %d, msg : %s", sock_fd, send_msg); @@ -1526,9 +1543,11 @@ static int _recorder_create_common(recorder_h *recorder, muse_recorder_type_e ty send_msg = NULL; if (send_ret < 0) { +//LCOV_EXCL_START LOGE("send msg failed %d", errno); ret = RECORDER_ERROR_INVALID_OPERATION; goto _ERR_RECORDER_EXIT; +//LCOV_EXCL_STOP } pc->cb_info = _recorder_client_callback_new(sock_fd); @@ -1550,15 +1569,19 @@ static int _recorder_create_common(recorder_h *recorder, muse_recorder_type_e ty muse_recorder_msg_get_pointer(handle, pc->cb_info->recv_msg); if (handle == 0) { +//LCOV_EXCL_START LOGE("Receiving Handle Failed!!"); ret = RECORDER_ERROR_INVALID_OPERATION; goto _ERR_RECORDER_AFTER_CREATE; +//LCOV_EXCL_STOP } if (!_recorder_client_get_root_directory(&root_directory) || root_directory == NULL) { +//LCOV_EXCL_START LOGE("failed to get root directory of internal storage"); ret = RECORDER_ERROR_INVALID_OPERATION; goto _ERR_RECORDER_AFTER_CREATE; +//LCOV_EXCL_STOP } LOGD("root directory [%s]", root_directory); @@ -1587,7 +1610,7 @@ static int _recorder_create_common(recorder_h *recorder, muse_recorder_type_e ty LOGD("done"); return RECORDER_ERROR_NONE; - +//LCOV_EXCL_START _ERR_RECORDER_AFTER_CREATE: _recorder_msg_send(MUSE_RECORDER_API_DESTROY, pc->cb_info, &destroy_ret); LOGE("destroy return 0x%x", destroy_ret); @@ -1616,6 +1639,7 @@ _ERR_RECORDER_EXIT: } return ret; +//LCOV_EXCL_STOP } @@ -1730,6 +1754,7 @@ int recorder_unprepare(recorder_h recorder) LOGD("ENTER"); if (pc->camera) { +//LCOV_EXCL_START ret = camera_get_state(pc->camera, &camera_state); if (ret != CAMERA_ERROR_NONE) { LOGE("failed to get camera state 0x%x", ret); @@ -1743,6 +1768,7 @@ int recorder_unprepare(recorder_h recorder) return RECORDER_ERROR_INVALID_OPERATION; } } +//LCOV_EXCL_STOP } _recorder_msg_send(api, pc->cb_info, &ret); @@ -1768,6 +1794,7 @@ int recorder_start(recorder_h recorder) LOGD("ENTER"); if (pc->camera) { +//LCOV_EXCL_START ret = recorder_get_state(recorder, ¤t_state); if (ret != RECORDER_ERROR_NONE) { LOGE("failed to get current state 0x%x", ret); @@ -1781,6 +1808,7 @@ int recorder_start(recorder_h recorder) return RECORDER_ERROR_INVALID_OPERATION; } } +//LCOV_EXCL_STOP } _recorder_msg_send(api, pc->cb_info, &ret); @@ -1830,6 +1858,7 @@ int recorder_commit(recorder_h recorder) LOGD("ENTER"); if (pc->camera) { +//LCOV_EXCL_START ret = recorder_get_state(recorder, ¤t_state); if (ret != RECORDER_ERROR_NONE) { LOGE("failed to get current state 0x%x", ret); @@ -1843,6 +1872,7 @@ int recorder_commit(recorder_h recorder) return RECORDER_ERROR_INVALID_OPERATION; } } +//LCOV_EXCL_STOP } _recorder_msg_send(api, pc->cb_info, &ret); @@ -3318,9 +3348,11 @@ int recorder_get_device_state(recorder_type_e type, recorder_device_state_e *sta sock_fd = muse_core_client_new(); if (sock_fd < 0) { +//LCOV_EXCL_START LOGE("muse_core_client_new failed - returned fd %d", sock_fd); ret = RECORDER_ERROR_INVALID_OPERATION; goto _GET_DEVICE_STATE_EXIT; +//LCOV_EXCL_STOP } send_msg = muse_core_msg_json_factory_new(MUSE_RECORDER_API_GET_DEVICE_STATE, @@ -3328,9 +3360,11 @@ int recorder_get_device_state(recorder_type_e type, recorder_device_state_e *sta MUSE_TYPE_INT, PARAM_RECORDER_TYPE, type, NULL); if (!send_msg) { +//LCOV_EXCL_START LOGE("NULL msg"); ret = RECORDER_ERROR_OUT_OF_MEMORY; goto _GET_DEVICE_STATE_EXIT; +//LCOV_EXCL_STOP } LOGD("sock_fd : %d, msg : %s", sock_fd, send_msg); @@ -3341,22 +3375,28 @@ int recorder_get_device_state(recorder_type_e type, recorder_device_state_e *sta send_msg = NULL; if (ret < 0) { +//LCOV_EXCL_START LOGE("send msg failed %d", errno); ret = RECORDER_ERROR_INVALID_OPERATION; goto _GET_DEVICE_STATE_EXIT; +//LCOV_EXCL_STOP } ret = muse_core_ipc_recv_msg(sock_fd, recv_msg); if (ret <= 0) { +//LCOV_EXCL_START LOGE("recv msg failed %d", errno); ret = RECORDER_ERROR_INVALID_OPERATION; goto _GET_DEVICE_STATE_EXIT; +//LCOV_EXCL_STOP } if (!muse_recorder_msg_get(ret, recv_msg)) { +//LCOV_EXCL_START LOGE("failed to get return value from msg [%s]", recv_msg); ret = RECORDER_ERROR_INVALID_OPERATION; goto _GET_DEVICE_STATE_EXIT; +//LCOV_EXCL_STOP } if (ret == RECORDER_ERROR_NONE) { @@ -3447,6 +3487,7 @@ int recorder_add_device_state_changed_cb(recorder_device_state_changed_cb callba _DONE: if (ret != RECORDER_ERROR_NONE) { +//LCOV_EXCL_START if (info) { g_free(info); info = NULL; @@ -3456,6 +3497,7 @@ _DONE: g_object_unref(g_rec_dev_state_changed_cb_conn); g_rec_dev_state_changed_cb_conn = NULL; } +//LCOV_EXCL_STOP } g_mutex_unlock(&g_rec_dev_state_changed_cb_lock); |