summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDmitry Kovalenko <d.kovalenko@samsung.com>2015-09-14 15:31:40 +0300
committerDmitry Kovalenko <d.kovalenko@samsung.com>2015-09-22 00:38:55 -0700
commit4da0f48028fd1982a75a64292662203b36461b87 (patch)
treecb39149a867bc3694285effc69e3d6b27e3164fa
parent57f9522ba16b0742e4de38816507e5ab002fb2dc (diff)
downloadswap-modules-4da0f48028fd1982a75a64292662203b36461b87.tar.gz
swap-modules-4da0f48028fd1982a75a64292662203b36461b87.tar.bz2
swap-modules-4da0f48028fd1982a75a64292662203b36461b87.zip
[STYLE] Fix preload_threads_get_drop
Change-Id: If63f4874ff48ebe1f57221667a194d70c1a6bf15
-rw-r--r--preload/preload_module.c5
-rw-r--r--preload/preload_threads.c4
-rw-r--r--preload/preload_threads.h2
3 files changed, 5 insertions, 6 deletions
diff --git a/preload/preload_module.c b/preload/preload_module.c
index b23e38df..759d46f7 100644
--- a/preload/preload_module.c
+++ b/preload/preload_module.c
@@ -777,7 +777,6 @@ static int write_msg_handler(struct kprobe *p, struct pt_regs *regs)
unsigned long caller_offset;
unsigned long call_type_offset;
unsigned long caller_addr;
- bool drop;
int ret;
/* FIXME: swap_get_uarg uses get_user(), it might sleep */
@@ -793,8 +792,8 @@ static int write_msg_handler(struct kprobe *p, struct pt_regs *regs)
return 0;
}
- ret = preload_threads_get_drop(current, &drop);
- if (ret == 0 && drop)
+ ret = preload_threads_get_drop(current);
+ if (ret > 0)
return 0;
buf = kmalloc(len, GFP_ATOMIC);
diff --git a/preload/preload_threads.c b/preload/preload_threads.c
index b8c2b772..c700b966 100644
--- a/preload/preload_threads.c
+++ b/preload/preload_threads.c
@@ -257,14 +257,14 @@ get_call_type_done:
return ret;
}
-int preload_threads_get_drop(struct task_struct *task, bool *drop)
+int preload_threads_get_drop(struct task_struct *task)
{
struct thread_slot *slot;
int ret = 0;
slot = __get_task_slot(task);
if (slot != NULL) {
- *drop = slot->drop;
+ ret = (int) slot->drop;
goto get_drop_done;
}
diff --git a/preload/preload_threads.h b/preload/preload_threads.h
index 9020fb84..a82c0e62 100644
--- a/preload/preload_threads.h
+++ b/preload/preload_threads.h
@@ -13,7 +13,7 @@ int preload_threads_set_data(struct task_struct *task, unsigned long caller,
int preload_threads_get_caller(struct task_struct *task, unsigned long *caller);
int preload_threads_get_call_type(struct task_struct *task,
unsigned char *call_type);
-int preload_threads_get_drop(struct task_struct *task, bool *drop);
+int preload_threads_get_drop(struct task_struct *task);
bool preload_threads_check_disabled_probe(struct task_struct *task,
unsigned long addr);
void preload_threads_enable_probe(struct task_struct *task, unsigned long addr);