summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYan Yin <yan.yin@intel.com>2012-08-02 21:16:42 +0800
committerYan Yin <yan.yin@intel.com>2012-08-02 21:17:13 +0800
commit1a89b9cf215668c23f477332190f8907cf5364ba (patch)
tree9e73bcb98a198b73007de501bce6ac9a5456ff0d
parentde78d32eb0ebbcd55ec7c8cc9eb6fc972d9616e0 (diff)
downloaddevice-manager-plugin-pinetrail-1.0_post.tar.gz
device-manager-plugin-pinetrail-1.0_post.tar.bz2
device-manager-plugin-pinetrail-1.0_post.zip
fix potential buffer overflow2.0_alpha1.0_post
-rw-r--r--device_engine.c8
-rw-r--r--packaging/device-manager-plugin-pinetrail.changes3
2 files changed, 6 insertions, 5 deletions
diff --git a/device_engine.c b/device_engine.c
index 766df4b..919915f 100644
--- a/device_engine.c
+++ b/device_engine.c
@@ -160,7 +160,6 @@ static int sys_read_buf(char *file, char *buf)
}
r = read(fd, buf, BUFF_MAX);
- DBG("!@#read[%s], value[%s], line[%d]", file, buf, __LINE__);
if ((r >= 0) && (r <= BUFF_MAX))
buf[r] = '\0';
else {
@@ -170,7 +169,6 @@ static int sys_read_buf(char *file, char *buf)
close(fd);
INFO("read %s, value= %s", file, buf);
- DBG("read[%s], value[%s], line[%d]", file, buf, __LINE__);
return 0;
}
@@ -198,7 +196,7 @@ static int sys_write_buf(char *file, char *buf)
int sys_get_int(char *fname, int *val)
{
- char buf[BUFF_MAX];
+ char buf[BUFF_MAX+1];
if (sys_read_buf(fname, buf) == 0) {
*val = atoi(buf);
@@ -211,7 +209,7 @@ int sys_get_int(char *fname, int *val)
char *sys_get_str(char *fname)
{
- char buf[BUFF_MAX];
+ char buf[BUFF_MAX+1];
char *r = NULL;
if (sys_read_buf(fname, buf) == 0)
@@ -222,7 +220,7 @@ char *sys_get_str(char *fname)
int sys_set_int(char *fname, int val)
{
- char buf[BUFF_MAX];
+ char buf[BUFF_MAX+1];
int r = -1;
snprintf(buf, sizeof(buf), "%d", val);
diff --git a/packaging/device-manager-plugin-pinetrail.changes b/packaging/device-manager-plugin-pinetrail.changes
index 40fbdc2..0f22b25 100644
--- a/packaging/device-manager-plugin-pinetrail.changes
+++ b/packaging/device-manager-plugin-pinetrail.changes
@@ -1,2 +1,5 @@
+* Thu Aug 02 2012 Yan Yin <yan.yin@intel.com> build/2012-07-24.074803@797e50a
+- fix potential buffer overflow
+
* Tue Jul 24 2012 Yan Yin <yan.yin@intel.com> e2ab75d
- Initial device manager plugin for Pinetrail platform